Hmmm, this seems working as designed. Even in our classic Salt package.

AFAICS this plugin is not doing differently than the others, like venv-dnfnotify.py, venv-zyppnotify.py, etc, where we do not include the file in the bundle and then symlink but instead we do install the plugin file directly at /usr/bin/ or the corresponding place.

Do you think we should do this differently for all these plugins files? Or is there any particular reason for doing this differently for "venv-dpkgnotify"?

OTOH, I would like to prevent changing behaviors, if possible, on the "venv-salt-minion" at the same time we are validating the upgrade of Salt Bundle dependencies.

Alexander Graul (agraul) - over 1 year ago

I would expect that applications are installed to $VIRTUAL_ENV/bin/, like pip install does when executed within a venv. It feels weird to install something outside of the virtual environment and then patch the shebang. I'd be in favor of changing this, but it's not a big deal.

We can leave it as it is for now if you prefer. Personally I think it would be okay to test the changes together, bundle:next is not really stable (as in unchanging) anyway, we're about to update the Salt code as soon as we can.