Overview
gtk4-rpmlintrc vs gtk4.rpmlintrc ? Pretty sure we are supposed to use -rpmlintrc?
HA! - Im wrong :-) and have done it the wrong way all the time it seems:
Note that using %{name}-rpmlintrc, instead of %{name}.rpmlintrc will work, but the latter is considered as best practice.
Look at the wiki history https://en.opensuse.org/index.php?title=openSUSE:Packaging_checks&action=history - Luciano changed this in October 2022 without consulting the mailing list or even the reviewer team.
defacto changing the rule for everybody based on personal taste (mind: there was once a push to rename all the rpmlintrc files according to the then-valid guidelines - so almost all packages have a -rpmlintrc and very few a .rpmlintrc)
Sorry, I didn't know there was a(n) discussion/effort about/towards -rpmlintrc / .rpmlintrc before.
It was a mistake of mine making that change without opening discussions/consulting other parties? Sure. However, calling it a "change of rule for everybody based on personal taste" is at least inaccurate, and a mistake at best.
That change I made was purely based on what I read in the documentation upstream (which I should've linked in there too) and thought at the time "Well, if upstream recommends .rpmlintrc over -rpmlintrc, why don't we?".
But I learned my lesson. Let me revert those changes.
Apologies, I did not mean it as rude as it came over.
Generally, changes to the guidelines are fine - but they should be raised upfront to make sure petite are aware of that.
I have no strong feelings towards - or . In this case (in earlier days, - were declined by the reviewers based on the guidelines; which is why it's important that such this are made public. Not everybody will be testing the guides daily )
No worries. In the end I understood what you said. Even though I didn't make that change based on my personal preferences, the way I did it made it look like so.
-Dbuild-tests=false
I'd like to know why you removed this one (in .changes)?
Did that happen by accident? - suspect so (I might have cludged it when subbing the keep tabs :-) )
Because when I accepted your SR 1076834, I didn't notice at the time you were passing it a second time.
Request History
luc14n0 created request
Move English translations to the tools sub-package.
gnome-review-bot accepted review
Check script succeeded
gnome-review-bot approved review
Check script succeeded
iznogood accepted request
Seems sane - xinfwd, review in G:F
