Overview

Request 1086647 accepted

- Add upstream bug fix patches:
+ 0e5b4c34.patch general: Use GtkSwitch active property
consistently. app-chooser sets the state instead of active
property. Similar to d7af60161d30c885ebab69c58b346896f1565387,
we really meant to set active (whether the switch is toggled)
and not the state (i.e. the color of the switch). Use
gtk_switch_set_active().
In properties we've already fixed this, but there's a lingering
call to gtk_switch_get_state(). This is probably fine because
state is in sync with active when the default handler is used,
but let's get :active, to be consistent and safe.
+ 6e37d15f.patch window-slot: Manage search props set with
action. Manages search property change through "search-visible"
action. The action triggers other related functions that if not
executed will causes buggy behavior.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2875

Loading...

Bjørn Lie's avatar

Upstream spelling fixed

Request History
Bjørn Lie's avatar

iznogood created request

- Add upstream bug fix patches:
+ 0e5b4c34.patch general: Use GtkSwitch active property
consistently. app-chooser sets the state instead of active
property. Similar to d7af60161d30c885ebab69c58b346896f1565387,
we really meant to set active (whether the switch is toggled)
and not the state (i.e. the color of the switch). Use
gtk_switch_set_active().
In properties we've already fixed this, but there's a lingering
call to gtk_switch_get_state(). This is probably fine because
state is in sync with active when the default handler is used,
but let's get :active, to be consistent and safe.
+ 6e37d15f.patch window-slot: Manage search props set with
action. Manages search property change through "search-visible"
action. The action triggers other related functions that if not
executed will causes buggy behavior.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2875


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Luciano Santos's avatar

luc14n0 accepted review

LGTM


Luciano Santos's avatar

luc14n0 approved review

LGTM


Bjørn Lie's avatar

iznogood accepted request

XinFwd

openSUSE Build Service is sponsored by