Overview

Request 108709 accepted

- Update to version 2.6.7:
+ Remove the trailing comma from the last enum item to silence
gcc -pedantic warnings.
+ Be lenient from "From " lines found in message headers.
(bgo#671680).

I didn't like this lintwarning, but I see we already have it like this, so I ignored it.

gmime-sharp.x86_64: E: devel-file-in-non-devel-package (Badness: 50) /usr/lib64/pkgconfig/gmime-sharp-2.6.pc
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

Loading...
Request History
Bjørn Lie's avatar

Zaitor created request

- Update to version 2.6.7:
+ Remove the trailing comma from the last enum item to silence
gcc -pedantic warnings.
+ Be lenient from "From " lines found in message headers.
(bgo#671680).

I didn't like this lintwarning, but I see we already have it like this, so I ignored it.

gmime-sharp.x86_64: E: devel-file-in-non-devel-package (Badness: 50) /usr/lib64/pkgconfig/gmime-sharp-2.6.pc
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.


Dominique Leuenberger's avatar

dimstar approved review

Looks good to me. About the deve-in-non-devel: it's questionable if you should have to require gmime-sharp when you build for mono or gmime-devel... and this .pc does not have dependencies, so it's not really an issue.


Dominique Leuenberger's avatar

dimstar accepted request

checkin


Dominique Leuenberger's avatar

dimstar accepted review

Looks good to me. About the deve-in-non-devel: it's questionable if you should have to require gmime-sharp when you build for mono or gmime-devel... and this .pc does not have dependencies, so it's not really an issue.

openSUSE Build Service is sponsored by