Overview
Careful: virtiofsd is marked ExclusiveArch: x86_64 - but qemu-tools is built for all archs. As a consequence, qemu-tools is not installable on any arch other than x86_64
Issue shown in https://build.opensuse.org/package/show/openSUSE:Factory:Staging:D/libvirt
Mmm... I see, and thanks for the review! Well, I'm not sure if (and if yes why) virtiofsd is restricted to that only arch. I'll check with @ccrane. It definitely was the case that the case that the old virtiofsd was available on other arch-es as well.
If the new one is x86_64 only, would an %ifarch around that one Requires: virtiofsd be a solution ? (or putting the dependency in an x86_64 only [sub]package, but I'm not sure there's one (and even if yes, I would like it a lot less...)
And, basing on this very quick experiment: https://build.opensuse.org/package/show/home:dfaggioli:experimental:Virtualization/virtiofsd it seems like it (virtiofsd) at least builds fine on other arch-es, in general, but there's an issue with 32 bit systems.
@dimstar , do you think that putting a %ifnarch %ix86 armv7hl around the Requires: would be a (good) solution ?
Difficult to say: if the tools can work without virtiofsd, then guarding it with ifnarch sounds good. If the tools don't actually work without it, then not so good
Hello! This version of QEMU depends on virtiofsd (as a 'Requires:', i.e., for installing, not for building), which is now its own separate package. It's not yet in Factory, but there's an SR for that already: https://build.opensuse.org/request/show/1088661
When you move that one %files section, might as well get rid of the %defattr line
Ok, and thanks for the review! Just to be sure I understand, which %defattr line I should be getting rid off?
All of them :D
Ah, cool! I thought it could be that, but was sidetracked by the "that one %file section". No problem, I'll do that
can't install qemu-tools-8.0.0-1.1.i586: nothing provides virtiofsd needed by qemu-tools-8.0.0.i586
Yeah, I know. I'll resubmit (and supersede thi SR) with that fixed
Request History
dfaggioli created request
- Patch added:
[openSUSE][RPM] Fix deps for virtiofsd and improve spec files
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:D"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:D got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:D got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:D got accepted.
This should "match" the virtiofsd package submitted to Factory in https://build.opensuse.org/request/show/1089199