Overview

Request 1089601 accepted

- Patch added:
[openSUSE][RPM] Fix deps for virtiofsd and improve spec files

Loading...

Dario Faggioli's avatar

This should "match" the virtiofsd package submitted to Factory in https://build.opensuse.org/request/show/1089199


Dominique Leuenberger's avatar

Careful: virtiofsd is marked ExclusiveArch: x86_64 - but qemu-tools is built for all archs. As a consequence, qemu-tools is not installable on any arch other than x86_64


Dominique Leuenberger's avatar

Issue shown in https://build.opensuse.org/package/show/openSUSE:Factory:Staging:D/libvirt


Dario Faggioli's avatar

Mmm... I see, and thanks for the review! Well, I'm not sure if (and if yes why) virtiofsd is restricted to that only arch. I'll check with @ccrane. It definitely was the case that the case that the old virtiofsd was available on other arch-es as well.

If the new one is x86_64 only, would an %ifarch around that one Requires: virtiofsd be a solution ? (or putting the dependency in an x86_64 only [sub]package, but I'm not sure there's one (and even if yes, I would like it a lot less...)


Dario Faggioli's avatar

And, basing on this very quick experiment: https://build.opensuse.org/package/show/home:dfaggioli:experimental:Virtualization/virtiofsd it seems like it (virtiofsd) at least builds fine on other arch-es, in general, but there's an issue with 32 bit systems.

@dimstar , do you think that putting a %ifnarch %ix86 armv7hl around the Requires: would be a (good) solution ?


Dominique Leuenberger's avatar

Difficult to say: if the tools can work without virtiofsd, then guarding it with ifnarch sounds good. If the tools don't actually work without it, then not so good


Dario Faggioli's avatar

Hello! This version of QEMU depends on virtiofsd (as a 'Requires:', i.e., for installing, not for building), which is now its own separate package. It's not yet in Factory, but there's an SR for that already: https://build.opensuse.org/request/show/1088661


Jan Engelhardt's avatar

When you move that one %files section, might as well get rid of the %defattr line


Dario Faggioli's avatar

Ok, and thanks for the review! Just to be sure I understand, which %defattr line I should be getting rid off?


Jan Engelhardt's avatar

All of them :D


Dario Faggioli's avatar

Ah, cool! I thought it could be that, but was sidetracked by the "that one %file section". No problem, I'll do that


Dominique Leuenberger's avatar
can't install qemu-tools-8.0.0-1.1.i586:
nothing provides virtiofsd needed by qemu-tools-8.0.0.i586

Dario Faggioli's avatar

Yeah, I know. I'll resubmit (and supersede thi SR) with that fixed

Request History
Dario Faggioli's avatar

dfaggioli created request

- Patch added:
[openSUSE][RPM] Fix deps for virtiofsd and improve spec files


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:D as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:D"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:D got accepted.

openSUSE Build Service is sponsored by