Overview
Request 1090475 accepted
- Update to version 20170907+ (commit b672b49f)
* Add support for indexed package format.
* Propagate anonymify to type aliases as well.
* Check if package was successfully resolved or not.
* Add package to cache when autocompleting unimported packages.
* Fix a bunch of type alias related autocompletion problems.
* Fix struct autocompletion.
* Better differentiation between func body and struct literal.
* Fix bug with type inference when shortcut return type syntax is used.
* Introduce godoc command and arg variables, restructure query
* Guard against packages not present on the cache
* Add a feature "canonical aliases".
* Make company-go an interactive Emacs function
* Rewrite package resolving code
* handle type alias
* support export/import of invalid aliases
* backport double-export fix for aliased objects
* implement support for importing aliases
- Provide emacs-company-go compiled with autoload if emacs company mode is available
- Provide emacs-autocomplete-golang if emacs autocomplete mode is
available.
Request History
eeich created request
- Update to version 20170907+ (commit b672b49f)
* Add support for indexed package format.
* Propagate anonymify to type aliases as well.
* Check if package was successfully resolved or not.
* Add package to cache when autocompleting unimported packages.
* Fix a bunch of type alias related autocompletion problems.
* Fix struct autocompletion.
* Better differentiation between func body and struct literal.
* Fix bug with type inference when shortcut return type syntax is used.
* Introduce godoc command and arg variables, restructure query
* Guard against packages not present on the cache
* Add a feature "canonical aliases".
* Make company-go an interactive Emacs function
* Rewrite package resolving code
* handle type alias
* support export/import of invalid aliases
* backport double-export fix for aliased objects
* implement support for importing aliases
- Provide emacs-company-go compiled with autoload if emacs company mode is available
- Provide emacs-autocomplete-golang if emacs autocomplete mode is
available.
jfkw accepted review
Review OK for devel:languages:go
jfkw approved review
Review OK for devel:languages:go
jfkw accepted request
Accept to devel:languages:go
Thanks for the submission Egbert. I took a look at the upstream repository, last commit was March 2019, later mentioning unmaintained status March 2023. This was a motivation to finish packaging of gopls, the official LSP server cited as successor in the gocode README.
gopls packaging was blocked on some challenges with the upstream monorepo layout, fixed. gopls is now in devel:languages:go, will be submitted to Factory soon.
Given the unmaintained status and a replacement, I think we should delete the accepted package from devel:languages:go. If development will be continuing on a fork, we should rename from
golang-github-nsf-gocodetogocodeto match the installed binary. The old naming convention was created during the GOPATH era. With Go modules, package names should reflect the binary name where possible.Thanks again.
Hi Jeff,
I'm fine with this, I've mainly updated gocode because it no longer built and I wanted it to see what works better for emacs -
emacs-eglotwithgoplsorgocodewithemacs-go-eldoc.I had packaged eglot as well. In fact, this was the reason for the fixes I had made to obs-service-go_modules - which you have accepted a while ago: the xml param element with the name-attribute 'subdir' was meant to deal with the gopls subdirectory in the monorepo layout of
golang-org-x-tools:<param name="subdir">gopls</param>