Overview

Request 1092570 superseded

- Removed invalid Recommends line

- Reintroduce removing /usr/bin/env from shebang lines as well as
duplicate files them selfs

- Do not package this as multi-python flavors: urlscan is a simple
leaf application written in python. Its python code is not
consumed by others.

- Update to urlscan 1.0.0
* Fix search with -c flag. Fixes #131.
* Add support for IPv6 URLs. Closes #127
* Mark items in url queue with a *
* Add version flag
* Update to pyproject.toml/hatch for builds
- Switch over to flavoured build
* Is there any way to have one major package e.g. for repeating
docs for the various flavoured sub packages?

Loading...
Request History
Dr. Werner Fink's avatar

WernerFink created request

- Removed invalid Recommends line

- Reintroduce removing /usr/bin/env from shebang lines as well as
duplicate files them selfs

- Do not package this as multi-python flavors: urlscan is a simple
leaf application written in python. Its python code is not
consumed by others.

- Update to urlscan 1.0.0
* Fix search with -c flag. Fixes #131.
* Add support for IPv6 URLs. Closes #127
* Mark items in url queue with a *
* Add version flag
* Update to pyproject.toml/hatch for builds
- Switch over to flavoured build
* Is there any way to have one major package e.g. for repeating
docs for the various flavoured sub packages?


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:35 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:35"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:35"


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar declined review

+Requires: %{python_module base}
+Requires: %{python_module urwid >= 1.2.1}

sorry, missed that. Requires must never use python_module (this would translate to all valid python versions; in this specific case probably not that bad, as pythons is defined to python3, but better not rely on this

as there is no actual python magic here, replace this with python3-FOO

(if this were a real python singlespec package, you'd use python-FOO and the macros would rewrite the spec)


Dominique Leuenberger's avatar

dimstar declined request

+Requires: %{python_module base}
+Requires: %{python_module urwid >= 1.2.1}

sorry, missed that. Requires must never use python_module (this would translate to all valid python versions; in this specific case probably not that bad, as pythons is defined to python3, but better not rely on this

as there is no actual python magic here, replace this with python3-FOO

(if this were a real python singlespec package, you'd use python-FOO and the macros would rewrite the spec)


openSUSE Build Service is sponsored by