Overview

Request 1092549 superseded

- Reintroduce removing /usr/bin/env from shebang lines as well as
duplicate files them selfs

- Do not package this as multi-python flavors: urlscan is a simple
leaf application written in python. Its python code is not
consumed by others.

- Update to urlscan 1.0.0
* Fix search with -c flag. Fixes #131.
* Add support for IPv6 URLs. Closes #127
* Mark items in url queue with a *
* Add version flag
* Update to pyproject.toml/hatch for builds
- Switch over to flavoured build
* Is there any way to have one major package e.g. for repeating
docs for the various flavoured sub packages?

Loading...

Dominique Leuenberger's avatar
found conflict of python310-urlscan-1.0.0-1.1.noarch with urlscan-0.9.10-1.2.noarch
  /usr/share/man/man1/urlscan.1.gz
  /usr/bin/urlscan

found conflict of python311-urlscan-1.0.0-1.1.noarch with urlscan-0.9.10-1.2.noarch
  /usr/share/man/man1/urlscan.1.gz
  /usr/bin/urlscan

found conflict of python39-urlscan-1.0.0-1.1.noarch with urlscan-0.9.10-1.2.noarch
  /usr/share/man/man1/urlscan.1.gz
  /usr/bin/urlscan

found conflict of python310-urlscan-1.0.0-1.1.noarch with urlscan-0.9.10-1.2.noarch
  /usr/lib/python3.10/site-packages/urlscan/__init__.py
  /usr/lib/python3.10/site-packages/urlscan/__main__.py
  /usr/lib/python3.10/site-packages/urlscan/urlchoose.py
  /usr/lib/python3.10/site-packages/urlscan/urlscan.py
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/__init__.cpython-310.opt-1.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/__init__.cpython-310.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/__main__.cpython-310.opt-1.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/__main__.cpython-310.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/urlchoose.cpython-310.opt-1.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/urlchoose.cpython-310.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/urlscan.cpython-310.opt-1.pyc
  /usr/lib/python3.10/site-packages/urlscan/__pycache__/urlscan.cpython-310.pyc
  /usr/lib/python3.10/site-packages/urlscan/assets/tlds-alpha-by-domain.txt

The upgrade path is not properly defined apparently


Dr. Werner Fink's avatar

Does this mean that the build scheme of the python now creates a package split ... how I can avoid this?


Dominique Leuenberger's avatar

you changed the package to be split per python version...

+%python_subpackages


-%files
-%license COPYING
-%{_bindir}/%{name}
-%{python_sitelib}/%{name}
-%{python_sitelib}/%{name}-%{version}-py*.egg-info
-%{_mandir}/man1/%{name}.1%{?ext_man}
-%dir %{_defaultdocdir}/%{name}/
-%doc %{_defaultdocdir}/%{name}/muttrc
-%doc %{_defaultdocdir}/%{name}/README.md
+%post
+%python_install_alternative %{myname}
+
+%postun
+%python_uninstall_alternative %{myname}
+
+%files %{python_files}
+%python_alternative %{_bindir}/%{myname}
+%python_alternative %{_mandir}/man1/%{myname}.1%{?ext_man}
+%{python_sitelib}/%{myname}
+%{python_sitelib}/%{myname}-%{version}*-info
+%license LICENSE
+%doc README.md muttrc

I don't see much reason to do so unless urlscan's python code is consumed by anything else than urlscan. Otherwise this is just to be considered internal to urlscan and does not justify it being shipped multiple times


Dr. Werner Fink's avatar

The old macros do not work anymore ... and the new seems to be for python only packages ...

[    5s] error: Package with "python-" prefix must not contain unmarked "%files" sections.
[    5s] error: Use "%files %python_files" or "%files %{python_files foo} instead.
[    5s] 


Dr. Werner Fink's avatar

I've used that in SR#1092549

Request History
Dr. Werner Fink's avatar

WernerFink created request

- Reintroduce removing /usr/bin/env from shebang lines as well as
duplicate files them selfs

- Do not package this as multi-python flavors: urlscan is a simple
leaf application written in python. Its python code is not
consumed by others.

- Update to urlscan 1.0.0
* Fix search with -c flag. Fixes #131.
* Add support for IPv6 URLs. Closes #127
* Mark items in url queue with a *
* Add version flag
* Update to pyproject.toml/hatch for builds
- Switch over to flavoured build
* Is there any way to have one major package e.g. for repeating
docs for the various flavoured sub packages?


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dr. Werner Fink's avatar

WernerFink superseded request

superseded by 1092570

openSUSE Build Service is sponsored by