Overview

Request 1094737 revoked

Append VERSION_ID to the PRETTY_NAME variable, in os-release


Luciano Santos's avatar

I wonder if this spec file is auto generated/tweaked by some bot.


Luciano Santos's avatar

Let's see what fails.


Luciano Santos's avatar

The source services shuffled a lot of things around. If that's unwanted, I'll re-sub.


Dominique Leuenberger's avatar

I don't think Version id has any business in the pretty name field.

Feels strange to 'rename' the distro every day


Luciano Santos's avatar

Well, (stable) distros usually have some form of NAME + VERSION/VERSION_ID combined. Here's Leap, for instance:

leap-container $ cat /etc/os-release 
NAME="openSUSE Leap"
VERSION="15.5"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.5"
PRETTY_NAME="openSUSE Leap 15.5"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.5"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
DOCUMENTATION_URL="https://en.opensuse.org/Portal:Leap"
LOGO="distributor-logo-Leap"

So, software like gnome-control-center (its About pane) show PRETTY_NAME, if available:

  if (pretty_name)
    return g_steal_pointer (&pretty_name);
  else if (name && version_id)
    return g_strdup_printf ("%s %s", name, version_id);
  else
    return g_strdup (_("Unknown"));

I think it would be beneficial for us to show the snapshot version the user's Tumbleweed system is (on the About pane) and I'm trying to figure out the best approach / how feasible this would be: to tweak os-release or possibly gnome-control-center.

"Feels strange to 'rename' the distro every day"

Hmm, it'd fit Tumbleweed's nature well, the ever changing distro, wouldn't it? :^P


Dominique Leuenberger's avatar

And yes - 000release-packages is auto generated. The leading package which would need to be changed is 000package-groups

Request History
Luciano Santos's avatar

luc14n0 created request

Append VERSION_ID to the PRETTY_NAME variable, in os-release


Factory Auto's avatar

factory-auto accepted review

Skipping all checks for meta packages


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse declined request

000release-packages is auto-generated based on the templates in 000package-groups

This change would be discarded within a few hours.

and besides that:
I don't think Version id has any business in the pretty name field.

Feels strange to 'rename' the distro every day


Luciano Santos's avatar

luc14n0 revoked request

Wrong place.

openSUSE Build Service is sponsored by