Overview
no need to guard it for undefined: we want to be all flavors have it defined (empty flavor intentionally defines it to %nil)
this makes no sense: on TW, python_modules expands to all python flavors. meson is part of ring0 (distro bootstrap) and consuming more than the main distro version is not wanted at all
i.e this works as your prjconf contains
%pythons %{?!skip_python2:python2} %{?!skip_python3:python3}
this can't be duplicated into TW
without %python_subpackages in use, these python-* macros won't be translated and will be in the RPM literally as python-*
this confirms it in the 15.5 build of meson
that sounds noble, but imho is even more confusing.
better use %endif %dnl with setuptools
I got everything working on Tumbleweed, Leap 15.5 still fails. Help is much appreciated.
as for the 15.5 test suite:
shebang of /usr/bin/meson on 15.5 is:
#!/usr/bin/python3 from mesonbuild.mesonmain import main import sys
as such it tries to load the python modules for meson out of the default python version directories (3.6), not from the 3.11 flavor
Request History
gladiac created request
- Use sle15_python_module_pythons
- Some spec cleanup
- Added meson-test-remove-python2.patch
gnome-review-bot accepted review
Check script succeeded
gnome-review-bot approved review
Check script succeeded
dimstar declined request
See comments
This line is deprecated- we have no maintained distro left that does not define python_module (where we care for new meson)
there is no %python_subpackages - this results in a literal python3-setuptools Requires. No sir :)
I don't understand this comment - when are we ever changing %bindir?
changing the source tree in check? really bad idea (you could not shortcut twice to check - 2nd run will always fail, as it can't remove the files anymore)
Leave this in %prep - aka 'prepare source tree'
'why'..
proper changelogs answer 4WH at least - or they are not good enough
Who did What When (who and when are in the changelog header - osc vc). How was this done and why?
%{?sle15_python_module_pythons} +%if 0%{?suse_version} >= 1550 || 0%{?sle_version} >= 150500 +%define pythons python311 +%define mypython python311 +%define mypython_sitelib %{python311_sitelib}This is duplicated logic: the sle15_python_module_pythons does not do more than set pythons to python311 (or what is set in prjconf)