Overview
Request 1096546 revoked
- Use sle15_python_module_pythons for SLE and Leap
- Added meson-test-remove-python2.patch
* Removes running tests with python2. It is disabled with
sle15_python_module_pythons
- As meson does not create python submodules we should just settle on one
python version. This fixes building on Leap.
This line is deprecated- we have no maintained distro left that does not define python_module (where we care for new meson)
there is no %python_subpackages - this results in a literal python3-setuptools Requires. No sir :)
I don't understand this comment - when are we ever changing %bindir?
changing the source tree in check? really bad idea (you could not shortcut twice to check - 2nd run will always fail, as it can't remove the files anymore)
Leave this in %prep - aka 'prepare source tree'
'why'..
proper changelogs answer 4WH at least - or they are not good enough
Who did What When (who and when are in the changelog header - osc vc). How was this done and why?
%{?sle15_python_module_pythons}
+%if 0%{?suse_version} >= 1550 || 0%{?sle_version} >= 150500
+%define pythons python311
+%define mypython python311
+%define mypython_sitelib %{python311_sitelib}
This is duplicated logic: the sle15_python_module_pythons does not do more than set pythons to python311 (or what is set in prjconf)
Request History
gladiac created request
- Use sle15_python_module_pythons for SLE and Leap
- Added meson-test-remove-python2.patch
* Removes running tests with python2. It is disabled with
sle15_python_module_pythons
- As meson does not create python submodules we should just settle on one
python version. This fixes building on Leap.
gnome-review-bot accepted review
Check script succeeded
gnome-review-bot approved review
Check script succeeded
gladiac revoked request
This is still exactly the same as above -
%sle15_python_moudle_pythonsIf I remove this, it stops to work.
That should actually not be nescesary - or even wanted: we install meson.rpm when running the test flavor and expect this to work without any relevance of the buildroot; if this is needed, then something must be broken
There is still a strange problem with tests, clang-tidy doesn't find the cstdio header file.
@XRevan86, @dimstar: review reminder