Overview
Request 1097042 accepted
- Update to 3.0.1:
* VDO a KBD plugins were removed.
* New NVMe plugin was added.
* Runtime dependencies are no longer checked during plugin
initialization.
* Part plugin was rewritten to use libfdisk instead of libparted
* Crypto plugin API went through an extensive rewrite.
* Support for new technologies was added to the crypto plugin:
FileVault2 encryption, DM Integrity, LUKS2 tokens.
* Filesystem plugin adds support for btrfs, F2FS, NILFS2,
exFAT and UDF.
* Support for new filesystem operations was added to the plugin:
setting label and UUID, generic mkfs function and API
for getting feature support for filesystems.
* dmraid support was removed from the DM plugin.
* Python 2 support was dropped.
* loop: define LOOP_SET_BLOCK_SIZE is not defined
* crypto: Remove stray struct redefinition
* fs: Simplify struct BDFSInfo
* vdo_stats: Remove unused libparted include
* lvm: Make _vglock_start_stop static
* fs: Add missing copy and free functions to the header file
- Drop no longer needed libblockdev-fix-libkmod-include.patch
- Created by polslinux
- In state accepted
- 7 package maintainers
- Supersedes 1096141
I'm going to take a look at this submission on Sunday.
Sorry for the delay. Today I'm going to spare some time to review this submission.
Again, sorry for the delay Paolo.
Apart from the long lines that should be wrapped to be no longer than 67 characters, what's bugging me are all those changes in the spec file without any mention is the changes file entry, and why they're needed:
+%if 0%{?suse_version} < 1590 +BuildRequires: gcc11 +%endif ... +BuildRequires: libext2fs-devel +BuildRequires: libfdisk-devel +BuildRequires: libnvme-devel >= 1.3 ... -%{?with_python2:BuildRequires: python-devel} ... +BuildRequires: keyutils-devel
Once those changes get documented, I'm confident we can forward this new release. I might take this opportunity to make some modifications that are long wainted, and I've sort of procrastineted the best I could.
I also took the liberty to search around to see what packages are using libblockdev, to see if they'd fail with this major version bump, and UDisks 2 remains its sole consumer - which already has a 2.10 release to adapt whatever needs to be adapted to work with libblockdev 3.0.
For the additional devel deps: I've added them because otherwise the build will fail. If we don't want them, we'd have to disable some options (e.g. https://github.com/storaged-project/libblockdev/blob/42be0697169489600ba1470d5cab39adcd730624/misc/install-test-dependencies.yml#L36C1-L39)
I understand that. What I meant is that we shouldn't skip documenting those kinds of modifications to the spec in the changes file entry. This time I'm gonna add them myself, as I have modifications of my own to do. You can see the result later.
Request History
polslinux created request
- Update to 3.0.1:
* VDO a KBD plugins were removed.
* New NVMe plugin was added.
* Runtime dependencies are no longer checked during plugin
initialization.
* Part plugin was rewritten to use libfdisk instead of libparted
* Crypto plugin API went through an extensive rewrite.
* Support for new technologies was added to the crypto plugin:
FileVault2 encryption, DM Integrity, LUKS2 tokens.
* Filesystem plugin adds support for btrfs, F2FS, NILFS2,
exFAT and UDF.
* Support for new filesystem operations was added to the plugin:
setting label and UUID, generic mkfs function and API
for getting feature support for filesystems.
* dmraid support was removed from the DM plugin.
* Python 2 support was dropped.
* loop: define LOOP_SET_BLOCK_SIZE is not defined
* crypto: Remove stray struct redefinition
* fs: Simplify struct BDFSInfo
* vdo_stats: Remove unused libparted include
* lvm: Make _vglock_start_stop static
* fs: Add missing copy and free functions to the header file
- Drop no longer needed libblockdev-fix-libkmod-include.patch
luc14n0 accepted review
LGTM
luc14n0 approved review
LGTM
luc14n0 accepted request
Accepting, but not forwarding yet.
do you want me to take a look also at UDisks2?
Well, I'm not the maintainer of UDisks, but feel free to do as you wish. Help is always appreciated :^)