Overview
Request 1098396 revoked
- Update to version 1.5:
* fabrics: Relax match on well known disc ctrl lookup
* tree: Ignore NULL address pointer for phy slot lookup
* fabrics: Filter discovery ctrls out during application context check
* util: Add ignored error code
* json: Use memory block allocated by realloc() instead printbuf
* tree: Add PCI physical slot number for controller
* tree: Use nvme_ipaddrs_eq() to compare IP addresses
* fabrics: Add EADDRNOTAVAIL error mapping
* fabrics: filter out subsystems with non-matching application string
* libnvme: add 'application' setting to nvme_root
* libnvme: add 'application' setting to the subsystem
* util: rename ipaddrs_eq() to nvme_ipaddrs_eq() and make public.
* util: Add ipaddrs_eq() to check whether two IP addresses are equal
* ioctl: fix RAE bit on last Get Log Page command
* fabrics: check genctr after getting discovery entries
* fabrics: handle /dev/nvme-fabrics read failure
* fabrics: fix potential invalid memory access in __nvmf_supported_option()
* Python: Fix crash during garbage collection
* mi: Add nvme_mi_ctrl_id to retrieve controller ID
* ioctl: Explicitly initialize all members of struct nvme_ns_mgmt_args
* ioctl: io management send, receive args fix
* Python: Add NBFT support
* tree: Fix offset argument check in nvme_bytes_to_lba
* nbft: add NBFT v1.0 table support
* types: Add IO command set specific field on nsmgmt
* fabrics: Do not pass unsupported options to kernel
* types: Add ns-mgmt host software specified fields
* types.h: Add FDP related Status Code
* tree: Fix argument check in nvme_bytes_to_lba
Request History
wagi created request
- Update to version 1.5:
* fabrics: Relax match on well known disc ctrl lookup
* tree: Ignore NULL address pointer for phy slot lookup
* fabrics: Filter discovery ctrls out during application context check
* util: Add ignored error code
* json: Use memory block allocated by realloc() instead printbuf
* tree: Add PCI physical slot number for controller
* tree: Use nvme_ipaddrs_eq() to compare IP addresses
* fabrics: Add EADDRNOTAVAIL error mapping
* fabrics: filter out subsystems with non-matching application string
* libnvme: add 'application' setting to nvme_root
* libnvme: add 'application' setting to the subsystem
* util: rename ipaddrs_eq() to nvme_ipaddrs_eq() and make public.
* util: Add ipaddrs_eq() to check whether two IP addresses are equal
* ioctl: fix RAE bit on last Get Log Page command
* fabrics: check genctr after getting discovery entries
* fabrics: handle /dev/nvme-fabrics read failure
* fabrics: fix potential invalid memory access in __nvmf_supported_option()
* Python: Fix crash during garbage collection
* mi: Add nvme_mi_ctrl_id to retrieve controller ID
* ioctl: Explicitly initialize all members of struct nvme_ns_mgmt_args
* ioctl: io management send, receive args fix
* Python: Add NBFT support
* tree: Fix offset argument check in nvme_bytes_to_lba
* nbft: add NBFT v1.0 table support
* types: Add IO command set specific field on nsmgmt
* fabrics: Do not pass unsupported options to kernel
* types: Add ns-mgmt host software specified fields
* types.h: Add FDP related Status Code
* tree: Fix argument check in nvme_bytes_to_lba
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
anag+factory set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:I"
darix accepted review
Accepted review for by_group opensuse-review-team request 1098396 from user factory-auto
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
anag+factory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:H"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
anag+factory set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:B"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:B"
anag+factory declined review
sr#1099915 has newer source and is from the same project
anag+factory declined request
sr#1099915 has newer source and is from the same project
wagi revoked request
https://build.opensuse.org/request/show/1099870
Makes nvme-cli FTBFS:
[ 20s] [20/74] cc -Invme.p -I. -I.. -Iccan -I../ccan -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fomit-frame-pointer -D_GNU_SOURCE -include config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -MD -MQ nvme.p/nvme-models.c.o -MF nvme.p/nvme-models.c.o.d -o nvme.p/nvme-models.c.o -c ../nvme-models.c [ 20s] [21/74] cc -Invme.p -I. -I.. -Iccan -I../ccan -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fomit-frame-pointer -D_GNU_SOURCE -include config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -MD -MQ nvme.p/nvme-rpmb.c.o -MF nvme.p/nvme-rpmb.c.o.d -o nvme.p/nvme-rpmb.c.o -c ../nvme-rpmb.c [ 21s] [22/74] cc -Invme.p -I. -I.. -Iccan -I../ccan -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fomit-frame-pointer -D_GNU_SOURCE -include config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -MD -MQ nvme.p/nvme-wrap.c.o -MF nvme.p/nvme-wrap.c.o.d -o nvme.p/nvme-wrap.c.o -c ../nvme-wrap.c [ 21s] FAILED: nvme.p/nvme-wrap.c.o [ 21s] cc -Invme.p -I. -I.. -Iccan -I../ccan -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fomit-frame-pointer -D_GNU_SOURCE -include config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -MD -MQ nvme.p/nvme-wrap.c.o -MF nvme.p/nvme-wrap.c.o.d -o nvme.p/nvme-wrap.c.o -c ../nvme-wrap.c [ 21s] ../nvme-wrap.c: In function ‘nvme_cli_ns_mgmt_create’: [ 21s] ../nvme-wrap.c:384:24: error: too few arguments to function ‘nvme_ns_mgmt_create’ [ 21s] 384 | return nvme_ns_mgmt_create(dev_fd(dev), ns, nsid, timeout, csi); [ 21s] | ^~~~~~~~~~~~~~~~~~~ [ 21s] In file included from /usr/include/nvme/linux.h:14, [ 21s] from /usr/include/libnvme.h:18, [ 21s] from ../nvme-wrap.c:9: [ 21s] /usr/include/nvme/ioctl.h:3048:19: note: declared here [ 21s] 3048 | static inline int nvme_ns_mgmt_create(int fd, struct nvme_id_ns *ns, [ 21s] | ^~~~~~~~~~~~~~~~~~~ [ 21s] ../nvme-wrap.c:386:24: error: too few arguments to function ‘nvme_mi_admin_ns_mgmt_create’ [ 21s] 386 | return nvme_mi_admin_ns_mgmt_create(dev->mi.ctrl, ns, [ 21s] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 21s] In file included from /usr/include/libnvme-mi.h:17, [ 21s] from ../nvme-wrap.c:10: [ 21s] /usr/include/nvme/mi.h:2477:19: note: declared here [ 21s] 2477 | static inline int nvme_mi_admin_ns_mgmt_create(nvme_mi_ctrl_t ctrl, [ 21s] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 21s] [23/74] cc -Invme.p -I. -I.. -Iccan -I../ccan -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fomit-frame-pointer -D_GNU_SOURCE -include config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -MD -MQ nvme.p/nvme.c.o -MF nvme.p/nvme.c.o.d -o nvme.p/nvme.c.o -c ../nvme.c [ 21s] [24/74] cc -Invme.p -I. -I.. -Iccan -I../ccan -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fomit-frame-pointer -D_GNU_SOURCE -include config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -MD -MQ nvme.p/nvme-print.c.o -MF nvme.p/nvme-print.c.o.d -o nvme.p/nvme-print.c.o -c ../nvme-print.c [ 21s] ../nvme-print.c:2961:6: warning: conflicting types for ‘nvme_show_id_ctrl’ due to enum/integer mismatch; have ‘void(struct nvme_id_ctrl *, enum nvme_print_flags, void (*)(__u8 *, struct json_object *))’ {aka ‘void(struct nvme_id_ctrl *, enum nvme_print_flags, void (*)(unsigned char *, struct json_object *))’} [-Wenum-int-mismatch] [ 21s] 2961 | void nvme_show_id_ctrl(struct nvme_id_ctrl *ctrl, enum nvme_print_flags flags, [ 21s] | ^~~~~~~~~~~~~~~~~ [ 21s] In file included from ../nvme-print.c:12: [ 21s] ../nvme-print.h:24:6: note: previous declaration of ‘nvme_show_id_ctrl’ with type ‘void(struct nvme_id_ctrl *, unsigned int, void (*)(__u8 *, struct json_object *))’ {aka ‘void(struct nvme_id_ctrl *, unsigned int, void (*)(unsigned char *, struct json_object *))’} [ 21s] 24 | void nvme_show_id_ctrl(struct nvme_id_ctrl *ctrl, unsigned int mode, [ 21s] | ^~~~~~~~~~~~~~~~~ [ 21s] ninja: build stopped: subcommand failed. [ 21s] INFO: autodetecting backend as ninja [ 21s] INFO: calculating backend command to run: /usr/bin/ninja -C /home/abuild/rpmbuild/BUILD/nvme-cli-2.4/x86_64-suse-linux -j 3 -v [ 21s] error: Bad exit status from /var/tmp/rpm-tmp.5fhxCm (%build) [ 21s] [ 21s] RPM build errors: [ 21s] Bad exit status from /var/tmp/rpm-tmp.5fhxCm (%build) [ 21s] ### VM INTERACTION START ### [ 21s] [ 16.375117][ T1] sysrq: Power Off [ 21s] [ 16.376054][ T256] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] build70 failed "build nvme-cli.spec" at Thu Jul 13 07:45:07 UTC 2023. [ 21s]Makes nvme-cli FTBFS
Fixed nvme-cli https://build.opensuse.org/request/show/1099861
@wagi could you please take a look to this:
btw, this is triggered with meson 1.2.0
I can't reproduce this locally nor via the build services: https://build.opensuse.org/package/live_build_log/home:wagi:branches:Base:System/libnvme/openSUSE_Factory/x86_64
And where does meson 1.2.0 come from? https://build.opensuse.org/package/show/openSUSE:Factory/meson is still 1.1.1.
Meson 1.2.0 is staged in Factory but not yet accepted https://build.opensuse.org/project/show/openSUSE:Factory:Staging:B The SR is https://build.opensuse.org/request/show/1099498
You can see the full build log at: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:B/libnvme/standard/x86_64
Found meson 1.2.0. Unfortunately, the logs don't help. Still struggling to understand why the *.pyc are even considered.
You only need to add them to the python binding package and install everything under %{python3_sitearch}/libnvme