Overview
Request 1099950 revoked
- Created by vicentebolea
- In state revoked
-
Open review for
opensuse-review-team
-
Open review for
factory-staging
Request History
vicentebolea created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:94"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:94"
darix declined request
mrueckert wrote (1099950),Using intree copies is a maintenance nightmare and should be avoided
anag+factory reopened request
Reopened via staging workflow.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:94"
anag+factory declined request
Declined via staging workflow.
vicentebolea revoked request
@daryx Thanks for the review I will resolve this. What does it mean intree copy in this context? I cannot find info of it. Thanks
@darix
He meant not to use the bundled version of protobuf provided in the tarball of paraview. Ideally, if there is a security update in protobuf, we'll update the distribution one and all the packages using protobuf will pick up the security fix. If packages such as this one, start using their own copy of protobut, it'll be hard to track by the security team.
Thanks for explanation. The problem with using the distribution protobuf is that it requires ParaView to be build with -std=c++17 which is not possible at the moment. Some changes will be needed to achieve that either upstream or in patch here. I will follow up sometime later.
@vicentebolea In my branch prj tried passing std=c++17 via CXXFLAGS with distro protobuf re-enabled, but that did not work either (though I checked the flag itself was used during compilation). Just FYI.
Thanks @badshah400. In PV CMAKE_CXX_STANDARD is set to 11 in VTK subdir. What we can do is to make the TU that uses protobuf to be built with c++7