Overview
Request 1103274 superseded
- Ship the settings schema as part of the library rather than the daemon
+ The library (which is also used by gnome-shell via gir) expects the schema
to be installed. Before this change, if the daemon is not installed the
loading application would crash.
One symptom of this is gnome-shell crashing when logging in to the Polari
IRC client (at least on MicroOS Aeon).
- Created by epaolantonio
- In state superseded
- Superseded by 1103354
Request History
epaolantonio created request
- Ship the settings schema as part of the library rather than the daemon
+ The library (which is also used by gnome-shell via gir) expects the schema
to be installed. Before this change, if the daemon is not installed the
loading application would crash.
One symptom of this is gnome-shell crashing when logging in to the Polari
IRC client (at least on MicroOS Aeon).
gnome-review-bot accepted review
Check script succeeded
dimstar declined review
This change violates the shared library packaging guidelines
consider the case where the library changes the so-version, which means the package is being renamed.
The two library versions are supposed to be installable in parallel - which would not be possible with the schema in the library package (file conflict on install)
dimstar declined request
This change violates the shared library packaging guidelines
consider the case where the library changes the so-version, which means the package is being renamed.
The two library versions are supposed to be installable in parallel - which would not be possible with the schema in the library package (file conflict on install)
epaolantonio superseded request
superseded by 1103354
dang! Was so focused on the actual crash that I didn't think of that. Sorry for the noise :)
What do you think it's the best course of action here @dimstar? Shipping
telepathy-loggerby default would workaround this issue definitely, but it's still a workaroundI guess the only correct way to fix this is to fix upstream to make it not a requirement
Different options:
telepathy-logger >= %{version}(the `>= %{version} is needed to ensure the newest library will always have what it needs. in some cases this can cause for the older compact lib, but that's rather rare in the schemas_
Yeah I thought about 2) as well with the same reserves. Upstream also looks kinda inactive so I think this can work without worrying much about backwards compatibility as you said.
Thanks for the review & feedback, will return back :)