Overview

Request 1104167 revoked

- Do not use screen during build: bash is part of the distro
bootstrap cycle, and the smaller we can have it, the better.
- Rnu run-tests also as part of the %check section, not the build
section.

I failed to find a reason for the 'screen' call - the test suite seems to pass the same way
In line of making bootstrap smaller, I'd like you to consdier this change (or let's discuss it)

Dr. Werner Fink's avatar
Dr. Werner Fink (WernerFink) -
target maintainer

Hmmm ... any way to test tty/terminal 

bash/bash> osc rbl home:dimstar:Factory bash openSUSE_Factory x86_64 | grep /dev/tty:
[   99s] < ./read2.sub: line 18: /dev/tty: No such device or address
[   99s] < ./read2.sub: line 27: /dev/tty: No such device or address
[   99s] < ./read2.sub: line 45: /dev/tty: No such device or address
[   99s] < ./read7.sub: line 37: /dev/tty: No such device or address
[   99s] < ./read7.sub: line 64: /dev/tty: No such device or address
[  102s] < ./test.tests: line 115: /dev/tty: No such device or address
[  117s] < ./vredir8.sub: line 10: /dev/tty: No such device or address
[  118s] /home/abuild/rpmbuild/SOURCES/run-tests: line 73: /dev/tty: No such device or address
[  207s] < ./read2.sub: line 18: /dev/tty: No such device or address
[  207s] < ./read2.sub: line 27: /dev/tty: No such device or address
[  207s] < ./read2.sub: line 45: /dev/tty: No such device or address
[  207s] < ./read7.sub: line 37: /dev/tty: No such device or address
[  207s] < ./read7.sub: line 64: /dev/tty: No such device or address
[  210s] < ./test.tests: line 115: /dev/tty: No such device or address
[  225s] < ./vredir8.sub: line 10: /dev/tty: No such device or address

this is a bad idea ... and I'd like to reject this without working /dev/tty

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
author source maintainer 
> osc rbl openSUSE:Factory bash standard x86_64 | grep /dev/tty
[  262s] < ./read2.sub: line 18: /dev/tty: No such device or address
[  262s] < ./read2.sub: line 27: /dev/tty: No such device or address
[  262s] < ./read2.sub: line 45: /dev/tty: No such device or address
[  262s] < ./read7.sub: line 37: /dev/tty: No such device or address
[  262s] < ./read7.sub: line 64: /dev/tty: No such device or address
[  265s] < ./test.tests: line 115: /dev/tty: No such device or address
[  280s] < ./vredir8.sub: line 10: /dev/tty: No such device or address

This seems not (or not only) to be introduced by my change

Can we run the test suite in a bash:testsuite flavor where we can have the screen dep?

Then we can build bash (and use it) without a dep on screen - and the test suite can run whatever it needs (not part of the distro bootstrap, but can be done later)

Dr. Werner Fink's avatar
Dr. Werner Fink (WernerFink) -
target maintainer

The test run short after build does not show those errors ... search for

env -i HOME=/home/abuild/rpmbuild/BUILD/bash-5.2 TERM=linux LD_LIBRARY_PATH= TMPDIR=/tmp/bash.wxRgkfa3J1 SCREENRC=/home/abuild/rpmbuild/BUILD/bash-5.2/screen.2s4xWr/bash SC
REENDIR=/home/abuild/rpmbuild/BUILD/bash-5.2/screen.2s4xWr screen -D -m /usr/bin/make -O -j4 V=1 VERBOSE=1 -j1 TESTSCRIPT=/home/abuild/rpmbuild/SOURCES/run-tests check
[   54s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/bash-5.2/builtins'

the %check section was done by

Sat Sep 24 13:57:27 UTC 2022 - Christopher Yeleighton giecrilj@stegny.2a.pl - add checks

Dr. Werner Fink's avatar
Dr. Werner Fink (WernerFink) -
target maintainer

Can we have a working terminal during build?

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
author source maintainer

I don't think we can easily change OBS in this regard.

Dr. Werner Fink's avatar
Dr. Werner Fink (WernerFink) -
target maintainer

The rpmbuild uses lua ... beside the posix function calls I miss things like mapped libc calls like forkpty() as then I could write a minimal pty/tty screen in lua.

Request History
Dominique Leuenberger's avatar

dimstar created request

- Do not use screen during build: bash is part of the distro
bootstrap cycle, and the smaller we can have it, the better.
- Rnu run-tests also as part of the %check section, not the build
section.

I failed to find a reason for the 'screen' call - the test suite seems to pass the same way
In line of making bootstrap smaller, I'd like you to consdier this change (or let's discuss it)

Dr. Werner Fink's avatar

WernerFink declined request

Nope ... only if I see a working /dev/tty aka all tests are perfomed

Dominique Leuenberger's avatar

dimstar revoked request

openSUSE Build Service is sponsored by
Places