Overview

Request 1105229 revoked

Looks like https://github.com/nextcloud/desktop/issues/5929
is not affecting at least my installation.

My Nextcloud (27,0,0,8)) server is behind haproxy and the issue is not affecting
this installation.

Updating the client and restarting the client app results in no connection losses.
The sync works like a charm without problems.

Maybe it's time to think about
* recommending an updated version of the server
* recomend to implement a workaround as mentioned in
https://github.com/nextcloud/desktop/issues/5929#issuecomment-1687489134

=> At least Tumbleweed should offer the latest versions of a software, no?

- Update to 3.9.3
+ Bugfix/fix filename encoding test on windows stable 3.9
- Update to 3.9.2
- Remove Kinetic, add Mantic to stable-3.9 in #5921
- [stable-3.9] Feature/check server availibility everyminute in #5928
- [stable-3.9] windows reserved word silently excluded - csync exclude.cpp in #5934
- [stable-3.9] Do not modify discovered files on disk if not necessary in #5958
- Update to 3.9.1
- [stable-3.9] Bugfix/unsupported filename on server in #5812
- [stable-3.9] Bugfix/remove stale caseclashcopies in #5817
- [stable-3.9] Build for Debian Bookworm in #5820
- [stable-3.9] Bugfix/checksum calculation stop on destruction in #5827
- [stable-3.9] prevent crash by resetting common pointer after deleting gobject menu in #5850
- [stable-3.9] Documentation for mass deployment. in #5857
- [stable-3.9] Update the documentation with information on how 'Edit locally' works. in #5858
- [stable-3.9] Fix typos found by codespell in #5859
- [stable-3.9] Remove seen Talk notificatios from Tray window. in #5869
- [stable-3.9] fix bulk upload of empty files in #5878
- [stable-3.9] add link in readme to nextcloud-releases correct page with binaries in #5880
- [stable-3.9] always propagate locked status to read-only or read/write for real file in #5883
- [stable-3.9] chore(CI): Sign .drone.yml file in #5887
- [stable-3.9] Added new state and new job to check if /index.php/204 is being redirected in #5894
- [stable-3.9] Fix crash and incorrect implementation of seen chat notofications removal in #5897
- [stable-3.9] Disable share view completely when server does not support/has disabled file sharing in #5900
- [stable-3.9] Set VFS PinState to Excluded for ignored files. in #5904
- [stable-3.9] Create placeholder while dehydrating if needed in #5906
- [stable-3.9] Fix password generation for shares, improve generator in #5908
- [stable-3.9] Fix expire date field in Share settings in #5907
- [stable-3.9] Fix SVG rendering error in SvgImageProvider in #5909
- [stable-3.9] Fix build of sharemodel.cpp on MSVC in #5913


Atri Bhattacharya's avatar

Believe we do not need this because we use SOURCE_DATE_EPOCH to set reproducible timestamps in the code. Based on line number 204 in the original spec file I have checked that this sets the date/time in the code to the last modified date/time of the VERSION.cmake file in the upstream tarball reproducibly.

# Set SOURCE_DATE_EPOCH to set __DATE__/__TIME__ based on tarball creation date and make build reproducible
export SOURCE_DATE_EPOCH=`date -r VERSION.cmake +"%s"`

Atri Bhattacharya's avatar

This OTOH may indeed be needed despite the use of SOURCE_DATE_EPOCH, I shall check.


Atri Bhattacharya's avatar

This is not needed either. I checked that the date imprinted on the doc pages correspond to the source last modified date and not the build date. The variable SOURCE_DATE_EPOCH takes care of this. Therefore, we do not need this patch at all. Thanks.


Atri Bhattacharya's avatar

@lrupp Appreciate the sr, but here is what I think about the update:

  • We do not know what causes the issue and apparently neither does upstream. Therefore, we do not know how many this will potentially affect. Anecdotally, I see that with versions 3.9.1/2/3 I can no longer sync against a server that I do not host myself.
  • It would be a mistake, in my opinion, to be dragged into a discussion about recommended server versions here. As noted in the upstream bug [1], the issue has also been reproduced nextcloud server 25.0.x which is still supported by nextcloud themselves. As long as we do not know for sure what versions this does and doesn't affect, I would suggest holding off on the update.
  • The workaround you mention is clearly not a feasible solution those who do not have control over the server configuration, which is probably most people.

Yes TW should have latest versions as long as the new version works. I find it difficult to endorse an update with such a glaring issue, that will no doubt set the cat among the pigeons for no one knows how many people.

In addition, a couple of things bother me about upstream's response to this:

  • Clearly, upstream has decided to introduce what seems to be a major feature into what going by version numbering should have been a bug fix. As a result, what used to work with 3.9.0 no longer does with 3.9.1 (with no change to server configurations). I would have understood if this were version 4.x or even 3.10.x and we could recommend folks updated minimum server requirements, but does that make sense for 3.9.0 -> 3.9.1?
  • It has been frustrating to note the lack of any response — or indeed any attempt to communicate — for a month since I opened the bug immediately after 3.9.1 was released. Indeed, we are still waiting for any actual progress from upstream in telling us what server versions or configs may be affected. Unacceptable, if you ask me.

In view of all this, I would suggest holding off on this update, especially now that we have started hearing from upstream after a while.

As I noted upstream, I could also revert the commit that introduces this "feature" and push everything else that versions 3.9.1 through 3.9.3 bring, but still waiting word from upstream as to whether that would be safe to do.


Lars Vogdt's avatar
author source maintainer target maintainer

I can no longer sync against a server that I do not host myself.

Isn't that something that should become a Bugreport against the used server? If the server is not working with a client version that - in turn - works with other server versions... ...wouldn't it be worth to get the two development groups to work together?

But it looks like we are talking about Owncloud vs. Nextcloud here (please correct me, if I'm wrong): in that case - especially as Nextcloud forked from Owncloud in the past for a reason - I would expect no solution. Ever. So it might be better to NOT expect/ recommend users to use the nextcloud-desktop package to connect to an Owncloud server in that case -- and instead recommend them to use a dedicated owncloud-desktop package?

I am wondering anyway, that the nextcloud-client still works with an Owncloud server ;-)

As long as we do not know for sure what versions this does and doesn't affect, I would suggest holding off on the update.

The less testing this version gets, the more problems might get in unnoticed. At the moment, none of the nextcloud-desktop users in openSUSE Tumbleweed have a chance to test - which is not really useful for them or any potential user of the next Leap version.

The workaround you mention is clearly not a feasible solution those who do not have control over the server configuration, which is probably most people.

As said: if Nextcloud 25.x is affected as well, I would expect upstream to react, if more people complain about a non-working client. If nobody cries, the pressure for upstream to look at the issue is very low...

Clearly, upstream has decided to introduce what seems to be a major feature into what going by version numbering should have been a bug fix.

We are not responsible for upstream version numbering. We never will. If Upstream decides to name the next version 10.0 or 1.00 is up to them. (Remember that openSUSE switched from 42.3 to 15.0 ?)

As I noted upstream, I could also revert the commit that introduces this "feature" and push everything else that versions 3.9.1 through 3.9.3 bring, but still waiting word from upstream as to whether that would be safe to do.

If you want to wait, you should IMHO claim an ETA, until you expect upstream to provide a fix. This is clearly not a security issue (thinking about coordinated release dates and responsible behavior of distributions and upstream people when it comes to security bugs), but without a responsible and clearly expressed behavior, nothing will go forward.

So what about communicating a clear deadline for an upstream fix. If this date is passed, release the latest version in Tumbleweed?


Atri Bhattacharya's avatar

According to this comment upstream, NextCloud server 25.0.x is affected as well. It does not seem like a server version or owncloud vs nextcloud issue but rather that all of a sudden some specific server configurations will become unusable after updating from 3.9.0 to 3.9.1.

If your point is to let this broken update loose upon the TW population as a test, I think I can go along with that. I suppose it will be possible to revert back to 3.9.0 if we get too many complaints, won't it? I genuinely do not know if we can do that, so please let me know. If so, let's go for it.

Thanks for the discussion.



Lars Vogdt's avatar
author source maintainer target maintainer

Thanks for the offer. But I decided to go without all the discussions and such and building the package in my home project for now. Happy go switch back later, if the official package gets useful for me again.


Atri Bhattacharya's avatar

We have resumed pushing the latest versions to factory for a while now already. JFYI

Request History
Lars Vogdt's avatar

lrupp created request

Looks like https://github.com/nextcloud/desktop/issues/5929
is not affecting at least my installation.

My Nextcloud (27,0,0,8)) server is behind haproxy and the issue is not affecting
this installation.

Updating the client and restarting the client app results in no connection losses.
The sync works like a charm without problems.

Maybe it's time to think about
* recommending an updated version of the server
* recomend to implement a workaround as mentioned in
https://github.com/nextcloud/desktop/issues/5929#issuecomment-1687489134

=> At least Tumbleweed should offer the latest versions of a software, no?

- Update to 3.9.3
+ Bugfix/fix filename encoding test on windows stable 3.9
- Update to 3.9.2
- Remove Kinetic, add Mantic to stable-3.9 in #5921
- [stable-3.9] Feature/check server availibility everyminute in #5928
- [stable-3.9] windows reserved word silently excluded - csync exclude.cpp in #5934
- [stable-3.9] Do not modify discovered files on disk if not necessary in #5958
- Update to 3.9.1
- [stable-3.9] Bugfix/unsupported filename on server in #5812
- [stable-3.9] Bugfix/remove stale caseclashcopies in #5817
- [stable-3.9] Build for Debian Bookworm in #5820
- [stable-3.9] Bugfix/checksum calculation stop on destruction in #5827
- [stable-3.9] prevent crash by resetting common pointer after deleting gobject menu in #5850
- [stable-3.9] Documentation for mass deployment. in #5857
- [stable-3.9] Update the documentation with information on how 'Edit locally' works. in #5858
- [stable-3.9] Fix typos found by codespell in #5859
- [stable-3.9] Remove seen Talk notificatios from Tray window. in #5869
- [stable-3.9] fix bulk upload of empty files in #5878
- [stable-3.9] add link in readme to nextcloud-releases correct page with binaries in #5880
- [stable-3.9] always propagate locked status to read-only or read/write for real file in #5883
- [stable-3.9] chore(CI): Sign .drone.yml file in #5887
- [stable-3.9] Added new state and new job to check if /index.php/204 is being redirected in #5894
- [stable-3.9] Fix crash and incorrect implementation of seen chat notofications removal in #5897
- [stable-3.9] Disable share view completely when server does not support/has disabled file sharing in #5900
- [stable-3.9] Set VFS PinState to Excluded for ignored files. in #5904
- [stable-3.9] Create placeholder while dehydrating if needed in #5906
- [stable-3.9] Fix password generation for shares, improve generator in #5908
- [stable-3.9] Fix expire date field in Share settings in #5907
- [stable-3.9] Fix SVG rendering error in SvgImageProvider in #5909
- [stable-3.9] Fix build of sharemodel.cpp on MSVC in #5913


Atri Bhattacharya's avatar

badshah400 declined request

As noted previously, please resubmit after dropping `nextcloud-desktop-remove-datetime.patch` and we will move this along. Thanks again for the sr.


Lars Vogdt's avatar

lrupp revoked request

openSUSE Build Service is sponsored by