Overview
Request 1105522 accepted
- Created by michael-chang
- In state accepted
Request History
michael-chang created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
anag+factory set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:I"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
anag+factory set openSUSE:Factory:Staging:L as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:L"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:L"
dimstar accepted review
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:L"
anag+factory set openSUSE:Factory:Staging:F as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:F"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:F"
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:F got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:F got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:F got accepted.
Hi @michael-chang
This change introduces a cycle with
BuildRequires: grub2-branding. I understand from the changelog that you want to get everything signed for secure boot, so what about moving grub2-branding from openSUSE-branding to grub2 directly?Hi Ana,
Thanks for the suggestion. Indeed that will work to fix the loop dependency, but I'd like to have the grub2-branding still being part of openSUSE branding given the customization is done by openSUSE release team, not me, so they may want full control of the package.
Perhaps grub can provide it's own grub-fonts subpackage to the branding package. They are re-created by the same parameters so that openQA won't notice a change and happy to move on. After that is all set, the branding package can change to use grub fonts sub-package as well ...
The grub2 BuildRequires in grub2-branding appeared not needed and should be removed. I have filed a ticket for that https://bugzilla.suse.com/show_bug.cgi?id=1214769
Thank you @michael-chang !
needs update to remove cycle