Overview
Request 1105959 revoked
- Update to version 4.12.1:
+ GtkGridView: Fix a crash when scrolling
+ GtkColumnView: Fix a refcounting issue in the new scroll_to api
+ GtkTreeView: Fix style classes for sort arrows
+ GtkEntry: Improve tracking of user changes (for undo)
+ GtkNotebook: Fix a critical when switching pages
+ GtkColor/FontDialogButton: Make these widgets activatable
+ GtkMenuButton:
- Fix problems with focus handling
- Fix problems with DND
+ Printing: Fix the cpdb backend build
+ GSK: Fix issues with color matrix nodes
+ Wayland: Fix a crash with compositors other than gnome-shell
+ Updated translations.
- Drop patches fixed upstream:
+ 0001-Revert-Meson-Simplify-pkgconfig-file-generator.patch
+ 6af9dc86.patch
- Created by iznogood
- In state revoked
- Supersedes 1105958
-
Open review for
gnome-maintainers
Request History
iznogood created request
- Update to version 4.12.1:
+ GtkGridView: Fix a crash when scrolling
+ GtkColumnView: Fix a refcounting issue in the new scroll_to api
+ GtkTreeView: Fix style classes for sort arrows
+ GtkEntry: Improve tracking of user changes (for undo)
+ GtkNotebook: Fix a critical when switching pages
+ GtkColor/FontDialogButton: Make these widgets activatable
+ GtkMenuButton:
- Fix problems with focus handling
- Fix problems with DND
+ Printing: Fix the cpdb backend build
+ GSK: Fix issues with color matrix nodes
+ Wayland: Fix a crash with compositors other than gnome-shell
+ Updated translations.
- Drop patches fixed upstream:
+ 0001-Revert-Meson-Simplify-pkgconfig-file-generator.patch
+ 6af9dc86.patch
gnome-review-bot accepted review
Check script succeeded
iznogood revoked request
Revoking
Not so sure the "upstream fix" for the pc file is as correct as we want it to be....
I believe so. Following their conversation, Fedora was satisfied with the fix, so I think we should be as well, as we're not doing anything exotic here.
But it seems they didn't add a check for
wayland-client.h. I'm seeing several packages failing with:I can't say where the bug is. On the failing packages there should've been a
-I /usr/include/waylandflag passed tocc, because openSUSE packages/usr/include/wayland/wayland-client.hinstead:$ cat /usr/lib64/pkgconfig/wayland-client.pc prefix=/usr includedir=${prefix}/include/wayland libdir=${prefix}/lib64 datarootdir=${prefix}/share pkgdatadir=${datarootdir}/wayland Name: Wayland Client Description: Wayland client side library Version: 1.22.0 Requires.private: libffi Libs: -L${libdir} -lwayland-client Libs.private: -lm -pthread -lrt Cflags: -I${includedir}With the
4.12.1release,wayland-clientis a requirement pulled by Gtk4 now, instead of something else that'd pull it before. So, I'm confused <shrugging>urk... - This is not the first time our packaging of wayland-xxx header files in "non-standard" location have exposed bugs in other programs depending on it.
@dimstar - I suppose we just have to bite in that bitter apple once again and go fixing stuff.
Since sadly that is work flying above my head in most cases, I need you and @luc14n0 to take the rains on that one.
I started to poke around when I saw the package failures, but so far either I haven't found out the right terms for the search engines or I'm chasing ghosts.
So you were right, it's not as correct as we want it to be :^P