Overview
Request History
ecsos created request
New package for graphite-web.
Test does not run.
mcepl declined request
py2pack is absolutely NOT *the arbiter elegantiarum* and generated files by it are EXPECTED to be cleaned up manually.
Concerning six, please, get rid of it. We don’t require or expect compatibility with Python 2.*.
Concerning pytests, please, investigate, what's the problem and just file the ticket upstream, and skip the failing tests.
If the code is so abandoned and unmaintained, that there is no help of them accepting at least our patches, I don’t think we want to have it in Factory.
Please, modify the package accordingly.
ecsos revoked request
Okay, I don't feel like playing around. My lifetime is too valuable for that.
If you don't want it, you already have it.
ok, and why don't they run? Is it some issue on the upstream side? Or our side? Could that be fixed?
Also, recently we went through a great pain cleaning the six dependency, could it be patched to not require it?
No idea why they do not run. Not a single one. As for the dependencies, I follow the packaging guideline using py2pack. And this is what comes out.
well, could be because they don't support any live python: https://github.com/txamqp/txamqp/blob/master/.travis.yml And creating an issue upstream would be probably pointless.
I took a look for myself, the dep was added to graphite-web back in 2011, maybe even earlier, it was probably there for the whole life of graphite-web. I wouldn't call it a "new dep". But the package never required it AFAIK and it doesn't run any tests...
I don't like the idea of integrating this package, but it was possibly needed here for a long time. @mcepl @StevenK what do you think?
The tests do not run because pytest isn't in BuildRequires, but even then, Python itself and Twisted have all vastly moved in the last six years that this repository has not been updated, so "not one test doesn't run" isn't correct either. My results are "65 failed, 3 passed, 12 skipped, 60 warnings".
Every package in devel:languages:python incurs a cost for us to maintain, and I can not see this one providing any benefit.
98% of the tests do not work or do not work without errors. You can already say that no test works.
And creating is a business. (Schaffe is halt a Geschäft) It has always been like that. These eternal arguments and fights are getting on my nerves.
pytest is not in require from src. And with BuildRequires pytest its the same. No test run well.
Here https://github.com/graphite-project/graphite-web/blob/master/requirements.txt Only ceres is optional. The package is missing from beginning of graphite-web. And I would like to note that before I took over graphite-web, it didn't work at all. Since I take care of it since 2018 it works.
@StevenK, @TheBlackCat, @alarrosa, @aplanas, @dgarcia, @dirkmueller, @glaubitz, @mcalabkova, @mcepl, @mimi_vx, @ojkastl_buildservice, @posophe, @rjschwei, @sleep_walker, @tbechtold: review reminder