Overview

Request 1108961 accepted

Sound doesn't not work in xrdp when using pipewire w/o this module. It has been requested on the Factory mailing list.


Staging Bot's avatar

@jacraig, @yfjiang, @yudaike: review reminder


Jason Craig's avatar
author source maintainer

I've never submitted a new package to factory. Am I supposed to review something? If so, what?


Joe S's avatar

Hi Jason,

You've already done more than I know how to do ( THANKS ) but it is confusing because that staging-bot message above seems to indicate it is looking for a review, as does the status above but on the request history on the right it says darix accepted review 4 days ago.

20230908 is compiling now but I suspect that something needs to be done here to change the "review" status to accept but I don't know what it is.


Jan Engelhardt's avatar

Reviews are requested from 6 different entities, which includes something like 3 bots/scripts for automated checks, 1 human to help look for package problems that were not autodetected, 1 human that is the maintainer of the submission target (Factory), and, most importantly for this case (and the reason a notification was sent):

1 package maintainer, because whoever submitted the package was not the maintainer itself.


Joe S's avatar

Hi Jengelh,

As per this message from bug 1214295 from Yifan Jiang, Jason was supposed to be added as a maintainer ( he was the submitter )

Hi Jason, Daike, thank you for helping out! I 
have put your name as maintainers
in the package, please check "osc maintainer 
X11:RemoteDesktop
pipewire-module-xrdp" for more details.

Here's the bug report referenced:

https://bugzilla.suse.com/show_bug.cgi?id=1214295#c23

But Jason is unsure what he needs to do to pass the review.

Possibly you could explain what he needs to do?

Thanks!


Jan Engelhardt's avatar

click on Approve below this text field


Joe S's avatar

The only Approve on this web page is the Approve text in your reply.

I assume that it only appears for the maintainers so Jason would have to do that but based on his reply I don't think he will see it either.

Request History
Jason Craig's avatar

jacraig created request

Sound doesn't not work in xrdp when using pipewire w/o this module. It has been requested on the Factory mailing list.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:2 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:2"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:2"


Marcus Rueckert's avatar

darix accepted review

Accepted review for by_group opensuse-review-team request 1108961 from user staging-bot


Jason Craig's avatar

jacraig accepted review

👍


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:2 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:2 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:2 got accepted.

openSUSE Build Service is sponsored by