This request is superseded by
request 1117607
(Show diff)
Overview
Request 1111464 superseded
No description set
- Created by simotek
- In state superseded
- Superseded by 1117607
-
Open review for
factory-staging
Loading...
Request History
simotek created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot set openSUSE:Factory:Staging:F as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:F"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:F"
darix accepted review
Accepted review for by_group opensuse-review-team request 1111464 from user staging-bot
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:F"
anag+factory superseded request
new cmake
The
change is broken. We want
-DNDEBUGand others to be set.@simotek any comments about this change for cmake? Newer versions are stuck because this.
It's not really stuck, is it. There are five or so packages that fell victim, libphonenumber (I think favogt determined the culprit was actually in abseil-cpp), polkit (fails because of rpmlint not cmake),.. maybe we just have to accept that some packages will break. It's not like e.g. gcc/glibc breaking some package far down the line which relied on an implicit
#includehas stopped gcc/glibc from getting updated (or maybe that was because it was not part of any ring, idk).The build failures are just a symptom of the root cause. We want -DNDEBUG for production builds.
I don't know what causes rust to fail in Staging:F. Building openSUSE:Factory/rust1.72 with
--alternative-project Fbuilds fine, so cmake can't be it.@jelgelh There were unrelated packages failing because this staging was shared by other packages waiting (like fmt) but rust failing to build comes from the cmake change. cmake is definitively stuck and I'm going to remove it while you and the other cmake maintainers agree on what to do.
I really cannot reproduce the problem;
cd openSUSE/Factory/rust1.72; osc build -p /tmp/p(which I've filled with cmake, cmake:mini and cmke:full) produces rust1.72 successfully even with the new cmake. Can we find a new staging with just cmake and rust1.72? Maybe there was something really weird going on in the old F.waiting flags discussion
Unignored: returned to active backlog.