Overview
Request 1111689 superseded
Automatic submission by obs-autosubmit
- Created by factory-maintainer
- In state superseded
- Superseded by 1121404
-
Open review for
opensuse-review-team
-
Open review for
factory-staging
Request History
factory-maintainer created request
Automatic submission by obs-autosubmit
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:12"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:12"
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar declined review
+Requires: libwebsockets19
Requiring libraries like this is almost always wrong - except if the library is dlopen()'ed and then the whole thing likely breaks when the library changes version.
a relevant dep for this package is auto-added already by RPM anyway:
> zypper info --requires ttyd
…
libwebsockets.so.19()(64bit)
dimstar declined request
+Requires: libwebsockets19
Requiring libraries like this is almost always wrong - except if the library is dlopen()'ed and then the whole thing likely breaks when the library changes version.
a relevant dep for this package is auto-added already by RPM anyway:
> zypper info --requires ttyd
…
libwebsockets.so.19()(64bit)
anag+factory reopened request
Reopened via staging workflow.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:12"
anag+factory declined request
Declined via staging workflow.
mrueckert wrote (1111689) Why do you need a custom requires for libwebsockets19? is the library loaded via dlopen()?