Request 1111949 (superseded)

This request is superseded by request 1111991 (Show diff)

Overview

Request 1111949 superseded

- Update to version 2.4.0+git20230918.02ed553:
* Fix time report function output string creation
- Update to version 2.4.0+git20230915.acb9f8b2:
* polkit, sudoers whitelist: add gnome-branding-Aeon (bsc#1215276)
- Update to version 2.4.0+git20230915.ac23757:
* dbus-services: update tukitd (bsc#1215216)
* FileDigestCheck: do not use hash as variable name
* FileDigestCheck: Adapt fstrings to python3.12 check
* test: Remove real_files opotional parameter
* Add 'nats' user for NATS Server
* Add 'signaling' user for Nextcloud Talk Signaling Server
* Add 'otobo' user and group, successor app for OTRS
* PythonCheck: Add python-sphinx-doctrees-leftover
* test: Allow external file content definition
* test: Allow list of files in get_tested_mock_package
* test: add test documentation
* test: each file now default to empty content
* test: mocked test_config_files
* test: mocked newly added multiple-pyc-version tests
* test: mocked test_duplicates tests
* Refactored FakePkg with a new helper method for cleaner code in get_tested_mock_package
* moved _gather_dep_info and _gather_aux to AbstractPkg
* CI: removed GSoC23 branch for CI workflow
* test: mocked python dependencies leftovers; and removed 2 binaries
* copied _gather_deps_info and _gather_aux functions to FakePkg class
* test: mocked test_python_dependencies_missing; also removed its two rpm binaries
* test: removed binaries used for testing python package dependencies from metadata and requires.txt
* test: mocked another metadata test that supports complex dependency statements
* test: mocked test for metadata check in python package
* test: mocked complex dependencies from metadata
* test: mocked test for python dependencies from requires.txt
* test: mocked test for python dependencies from metadata
* modified if condition in add_file_with_content function
* test: distutil test for python packages is mocked
* tests: Refactored Python package tests using mocking for docs, src, and tests
* test: Remove binary RPM packages with Python docs and docs modules
* test: modified test_python_doc_module_in_package with mocking
* test: mocked test_python_doc_in_package
* flake8: fixed flake8 warnings
* Flake8 suggestion
* Update main.yml for GitHub Actions on branch GSoC23
* No need to import FakePkg
* changes as suggested
* As suggested, I have made changes to to get_tested_mock_package to use API, instead of just kwargs
* Tried to mock a test: test_binary.py
* CI: Use pipx to install external dependencies
* flake8: ignored double quotes with a comment
* flake8: remove double quotes
* add flake8 extra plugins
* Use python-magic API when available
* test: Skip test_executable_stack when ldd-failed
* PythonCheck: Add check for *.pyc different version

Created by fbonazzi 8 months ago
In state superseded
Supersedes 1111551
Superseded by 1111991
Open review for openSUSE:Factory:Staging:G

Submit rpmlint

Comments for request 1111949 0
Comments for request 1111551 5

Dominique Leuenberger (dimstar) - 8 months ago

reviewer

Looking at the rpmlint-mini build failure, I'd guess something is wrong with

https://github.com/rpm-software-management/rpmlint/commit/227d5276e7886274378c47732486507286ed048a

the rpmlint-mini failure looks like this:

[   31s] Check time report (>1% & >0.1s):
[   31s] Traceback (most recent call last):
[   31s]   File "/home/abuild/rpmbuild/BUILDROOT/rpmlint-mini-2.4.0+git20230915.acb9f8b2-13.19.x86_64/opt/testing/bin/rpmlint.real", line 33, in <module>
[   31s]     sys.exit(load_entry_point('rpmlint==2.4.0', 'console_scripts', 'rpmlint')())
[   31s]   File "./rpmlint/cli.py", line 184, in lint
[   31s]   File "./rpmlint/lint.py", line 123, in run
[   31s]   File "./rpmlint/lint.py", line 108, in _run
[   31s]   File "./rpmlint/lint.py", line 130, in _maybe_print_reports
[   31s]   File "./rpmlint/lint.py", line 151, in _print_time_report
[   31s] ValueError: Invalid format specifier
[   31s] + test 1 -gt 0 -a 1 -lt 60
[   31s] + exit 1

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:G/rpmlint-mini/standard/x86_64

Filippo Bonazzi (fbonazzi) - 8 months ago

source maintainer

@danigm is this something you could look into?

Daniel Garcia (dgarcia) - 8 months ago

source maintainer

Yes, sure, let me check what's happening here.

Daniel Garcia (dgarcia) - 8 months ago

source maintainer

Fixed upstream and here's a request to fix this issue in the rpmlint package: https://build.opensuse.org/request/show/1111932

Filippo Bonazzi (fbonazzi) - 8 months ago

source maintainer

Cheers Daniel, I've accepted it and submitted it superseding this request.

Interestingly you were not set as a maintainer of rpmlint on OBS. I assume that was an oversight, so I've added you. This way in the future you can submit this kind of fix yourself.