Overview
Request 1112520 revoked
- Created by michael-chang
- In state revoked
-
Open review for
factory-staging
Request History
michael-chang created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
anag+factory set openSUSE:Factory:Staging:L as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:L"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:L"
darix accepted review
Accepted review for by_group opensuse-review-team request 1112520 from user anag+factory
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:L"
anag+factory set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:I"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
anag+factory set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:D"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:D"
anag+factory set openSUSE:Factory:Staging:L as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:L"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:L"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:L"
anag+factory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:H"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
anag+factory set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:E"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:E"
dimstar_suse declined request
Declining based on
@gary_lin
I'm working on a fix to require fde-tpm-helper-rpm-macros only for the architectures with the newer UEFI and TCG protocol, such as x86_64, aarch64, and riscv64.
Once things are settled and can be built without pcr-oracle in the chain, this can be resubmitted
michael-chang revoked request
OK
Hi @michael-chang @gary_lin
grub2 and shim updates are stuck because fde-tools and pcr-oracle are not built for i586. I don't think we want to build these two packages for i586, so ideally we would require them only on the arches where they are available.
fde-tools is built for i586 AFAICS: https://build.opensuse.org/package/show/openSUSE:Factory:LegacyX86/fde-tools
And I cannot see why pcr-oracle would be needed. There is no such package installed in build log for aarch64 or x86_64.
Oh, I see in fde-tools.spec: Requires: pcr-oracle >= 0.4.5 but pcr-oracle is not built for 32-bit
I'm working on a fix to require fde-tpm-helper-rpm-macros only for the architectures with the newer UEFI and TCG protocol, such as x86_64, aarch64, and riscv64.