Overview
Request 1113941 accepted
- Packaging imrpovements
* Summary and Description clarify the purpose of this CLI tool
* Use %%name macro where applicable to normalize common lines
across Go app packages. Also makes renaming binary easier when
required to handle package name conflict.
* Drop Requires: golang-packaging. The original macros for file
movements into GOPATH are obsolete with Go modules. Macro
go_nostrip is no longer needed with current binutils and Go.
* Remove %%{go_nostrip} macro which is no longer recommended
* Update to BuildRequires: golang(API) >= 1.14 matching go.mod
* Drop %%autosetup -D arg only needed for multiple invocations
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable but
none exist at this time.
* Drop mod=vendor, go1.14+ will detect vendor dir and auto-enable
Request History
jfkw created request
- Packaging imrpovements
* Summary and Description clarify the purpose of this CLI tool
* Use %%name macro where applicable to normalize common lines
across Go app packages. Also makes renaming binary easier when
required to handle package name conflict.
* Drop Requires: golang-packaging. The original macros for file
movements into GOPATH are obsolete with Go modules. Macro
go_nostrip is no longer needed with current binutils and Go.
* Remove %%{go_nostrip} macro which is no longer recommended
* Update to BuildRequires: golang(API) >= 1.14 matching go.mod
* Drop %%autosetup -D arg only needed for multiple invocations
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable but
none exist at this time.
* Drop mod=vendor, go1.14+ will detect vendor dir and auto-enable
jfkw accepted review
Review OK for devel:languages:go
jfkw approved review
Review OK for devel:languages:go
jfkw accepted request
Accept to devel:languages:go