This request supersedes:
request 1116333
(Show diff)
Overview
Loading...
reviewer
target maintainer
I'm unsure what 18+# nodebuginfo does.
Also the changes log isn't our regular format but Fedora format if I'm not mistaken. did you run spec-cleaner on the spec?
author
source maintainer
target maintainer
The nodebuginfo is most likely a copy-paste error. Thanks for the catch. I'm also gonna run it through the spec-cleaner again. One tab snuck in there. Ah, could very well be that I'm mixing changelog formats now. But I thought someone was requesting that from me not so long ago. I assume you are talking about mentioning the version number in the first line? It is indeed mentioned here: https://en.opensuse.org/openSUSE:Creating_a_changes_file_(RPM)#Version_updates
reviewer
target maintainer
Right, it really looks like it's there. Strange, I really never saw it in practise :)
Login required, please
login
in order to comment
nodebuginfoin the header comments is gone and spec-cleaner was used on the spec. The changelog is unchanged since mentioning the version update in the first line seems to be best practice now. I'd say pushing an initial commit qualifies for that too.@jubalh Thanks for accepting the SR!
You are right, it's redundant. But at least I see one advantage: Skimming the changelog for version changes becomes easier.