Request 1122902 (accepted)

This request supersedes: request 1122446 (Show diff)

Overview

Request 1122902 accepted

- Fix usage of %%lang_package

- Update to version 4.18.3
* cache: Fix overwritten error
* cache: Fix uncached value
- Fixes boo#1216682

- Update to version 4.18.2
* Cache property-not-found responses in XfconfCache
* Don't reset scheduled save timer on every write
* xfconf-query: Sort channel list (-l or -m alone)
* docs: Fix transfer type of xfconf_list_channels()
* docs: Add clarification about bindings
- Use lang_package as bnc#513786 has been closed as fixed almost
8 years ago.

Created by tux93 7 months ago
In state accepted
Supersedes 1122446

Submit xfconf

Comments for request 1122902 0
Comments for request 1122446 4

Manfred Hollstein (manfred-h) - 7 months ago

source maintainer

@darix: Mind to explain why you declined this request?

Ana Guerrero (anag+factory) - 7 months ago

reviewer

Look at the bottom of the requested history box:

darix declined request 28 minutes ago

mrueckert wrote (1122446), ,-%package lang,+%lang_package, Summary: Languages for package %{name}, Group: System/Localization, Requires: %{libname} = %{version},,,you can remove the complete subpackage as %lang_package expands to,,,rpm --eval '%lang_package',,%package lang ,Summary: Translations for package %{name} ,Group: System/Localization , ,Requires: %{name} = %{version} , ,Provides: %{name}-lang-all = %{version} ,BuildArch: noarch ,%description lang ,Provides translations for the "%{name}" package.,`` `,,with the code above i would assume the new lang package has a description containing,,,Summary: ...,```

Manfred Hollstein (manfred-h) - 7 months ago

source maintainer

Yeah, I saw that, but I don't understand what he's trying to complain.

This is the output of the current package:

$ rpm -qp xfconf-lang-4.18.1-2.1.noarch.rpm -i
Name        : xfconf-lang
Version     : 4.18.1
Release     : 2.1
Architecture: noarch
Install Date: (not installed)
Group       : System/Localization
Size        : 417144
License     : GPL-2.0-or-later
Signature   : RSA/SHA512, Sun Oct 29 16:16:31 2023, Key ID 35a2f86e29b700a4
Source RPM  : xfconf-4.18.1-2.1.src.rpm
Build Date  : Sun Oct 29 16:16:14 2023
Build Host  : i04-ch4a
Packager    : https://bugs.opensuse.org
Vendor      : openSUSE
URL         : https://docs.xfce.org/xfce/xfconf/start
Summary     : Languages for package xfconf
Description :
Provides translations to the package xfconf
Distribution: openSUSE Tumbleweed

And this is what it will look like in the new one:

$ rpm -q xfconf-lang -i
Name        : xfconf-lang
Version     : 4.18.3
Release     : 80.1
Architecture: noarch
Install Date: Wed Nov  1 19:38:49 2023
Group       : System/Localization
Size        : 417144
License     : GPL-2.0-or-later
Signature   : RSA/SHA256, Wed Nov  1 10:30:59 2023, Key ID 96b4a5ff1c7d51b9
Source RPM  : xfconf-4.18.3-80.1.src.rpm
Build Date  : Wed Nov  1 10:30:42 2023
Build Host  : i04-ch1a
Vendor      : obs://build.opensuse.org/home:manfred-h
URL         : https://docs.xfce.org/xfce/xfconf/start
Summary     : Translations for package xfconf
Description :
Provides translations to the package xfconf
Distribution: home:manfred-h:X11:xfce / openSUSE_Tumbleweed

I cannot see a reason why the request has been declined!

Manfred Hollstein (manfred-h) - 7 months ago

source maintainer

FWIW, the exact same package got accepted for openSUSE:Leap:15.6

Visit https://build.opensuse.org/request/show/1122452

Request History

tux93 created request 7 months ago

- Fix usage of %%lang_package

- Update to version 4.18.3
* cache: Fix overwritten error
* cache: Fix uncached value
- Fixes boo#1216682

factory-auto added opensuse-review-team as a reviewer 7 months ago

Please review sources

factory-auto accepted review 7 months ago

Check script succeeded

licensedigger accepted review 7 months ago

darix accepted review 7 months ago

Accepted review for by_group opensuse-review-team request 1122902 from user factory-auto
JFYI: you do not have to quote macros in the .changes file. the convert from changes to rpm %changelog will do that for you.