Overview

Request 1123452 revoked

No description set
Loading...
Request History
Konstantin Voinov's avatar

kill_it created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:18"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:18"


Saul Goodman's avatar

licensedigger accepted review

The legal review is accepted preliminary. The package may require actions later on.


Dominique Leuenberger's avatar

dimstar declined review

+# 'make' in Leap doesn't parse shell here
+%if 0%{?suse_version} < 1600
+Patch0: 01-fix-shell-in-make-for-leap.patch
+%endif

Don't add patches conditionally to the sources, as then the .src.rpm is not usable across versions.

Only apply the patch conditionally later on


Dominique Leuenberger's avatar

dimstar declined request

+# 'make' in Leap doesn't parse shell here
+%if 0%{?suse_version} < 1600
+Patch0: 01-fix-shell-in-make-for-leap.patch
+%endif

Don't add patches conditionally to the sources, as then the .src.rpm is not usable across versions.

Only apply the patch conditionally later on


Ana Guerrero's avatar

anag+factory reopened request

Reopened via staging workflow.


Ana Guerrero's avatar

anag+factory added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Ana Guerrero's avatar

anag+factory accepted review

Unstaged from project "openSUSE:Factory:Staging:adi:18"


Ana Guerrero's avatar

anag+factory declined request

Declined via staging workflow.


Konstantin Voinov's avatar

kill_it revoked request

openSUSE Build Service is sponsored by