Overview
Request 1123570 revoked
- Created by RBrownSUSE
- In state revoked
- Supersedes 1123568
- Open review for factory-staging
Request History
RBrownSUSE created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
anag+factory set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar accepted review
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:E"
anag+factory set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:I"
favogt_factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
favogt_factory accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
favogt_factory declined review
Breaks systemd-boot
favogt_factory declined request
Breaks systemd-boot
anag+factory reopened request
reopen for re-staging and get the error message
anag+factory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:H"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
anag+factory declined request
See comments
RBrownSUSE revoked request
@favogt_factory
Ok, excuse my ignorance, but I'm going to need some guidance here. Something is breaking systemd-boot, apparently?
That's not a particularly helpful comment, while a valid reason for rejection.
I wasn't even aware we were enabling systemd-boot on any MicroOS based system yet, so what is breaking? Is there some sort of logs somewhere that I can see, that you have, that made this determination?
Hi @sfalken
I didn't see the error message but I'm guessing this change is problematic:
I'm going to re-stage this package so we can get the exact error message but please keep in mind this SR will need an update.
Thanks. If any of the microOS variants are using systemd-boot, I'm unaware of it, and while this isn't my SR in the first place, I've certainly not been doing any sort of testing for compatibility.
@sfalken @RBrownSUSE
This change makes openSUSE-MicroOS:kvm-and-xen-sdboot fail to build:
Yep, got it, thanks, we'll get it fixed up.
I've filed a new SR here: https://build.opensuse.org/request/show/1124269 Placing the conditional con grub2 instead of snapper, and removing the grub2 requirement