Request 1124429 (superseded)

This request is superseded by request 1129091 (Show diff)

Overview

Request 1124429 superseded

Lets see if this now fixes more things then it breaks.

- Stick -DNDEBUG back into CMAKE_C_FLAGS. Can't find a spontaneous
resolution for projects relying on its presence.
- update to 3.27.7:
* Tests: Clarify RunCMake.CTestTimeout case name
* ctest: Restore support for --timeout values higher than default test timeout
* Help: Document CMP0124 behavior on already-set variables
* FindPostgreSQL: Add support for version 16
- update to 3.27.5:
* cmGeneratorTarget: support config-independent Fortran source queries
* cmComputeLinkInformation: compute link info for module-using targets
* FortranCInterface: forward CMAKE_OSX_DEPLOYMENT_TARGET
* cxxmodules: detect and message about non-compiled sources
* Source: Link libatomic when needed on any Linux architecture
* Help: MSVC_DEBUG_INFORMATION_FORMAT is initialized from associated variable
* FindBoost: Add support for Boost 1.83
* Autogen: Evaluate INTERFACE_AUTOMOC_MACRO_NAMES efficiently
* VS: Avoid unnecessary CUDA device linking for OBJECT libraries
- update to 3.27.4:
* Fix support for Intel compiler with modern GNU system compiler
* Graphviz: Restore support for per-target dependency graph options
* FindOpenSSL: Fix OpenSSL 3.0.0 version extraction
- Make %cmake_build insert RELWITHDEBINFO CFLAGS as well to avoid
projects overriding our %optflags with some cmake default.

Created by simotek 8 months ago
In state superseded
Supersedes 1104274 1105489
Superseded by 1129091
Open review for factory-staging
Open review for opensuse-review-team

Submit cmake

Ana Guerrero (anag+factory) - 8 months ago

reviewer

@simotek what's the difference with https://build.opensuse.org/request/show/1120469 ?

Dominique Leuenberger (dimstar) - 8 months ago

reviewer

IMHO we should skip this NDEBUG madness and revert the macro changes..

Even the referenced redhat bug is kinda not promising:

 Peter Hutterer 2019-04-08 06:58:05 UTC

This change is causing packages that rely on assert() to break, see e.g. bug 1696264.

Any reason you can't just add -Db_ndebug to the mesa build, instead of changing the behaviour of the build system?

Comment 13 Michael Catanzaro 2019-04-08 13:02:20 UTC

Traditionally, some packages expect to be compiled with NDEBUG and others simply don't. It's kinda expected that this change will break packages that haven't tested release builds. Keep in mind this is just making plain builds (distro builds) more similar to release builds.

Jan Engelhardt (jengelh) - 8 months ago

reviewer

we could also just remove llvm16 and rust 1.71 (llvm17 & rust 1.73 are fine), something that would normally happen in due time anyway

Dominique Leuenberger (dimstar) - 8 months ago

reviewer

we could also just not break things as long as we don't have to

Dominique Leuenberger (dimstar) - 8 months ago

reviewer

For completeness:

> dependson llvm16
llvm16 :
      MozillaFirefox
      MozillaThunderbird
      cnf-rs
      flux
      include-what-you-use
      river
      rpcs3
      rust1.70
      rust1.70:test
      rust1.71
      rust1.71:test
      rust1.72
      rust1.72:test
      velociraptor
      velociraptor:client
      waylock
      zig

There is quite a bit behind llvm16

Dominique Leuenberger (dimstar) - 11 months ago

reviewer

fallout: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:E/rdma-core/standard/x86_64

Ana Guerrero (anag+factory) - 11 months ago

reviewer

Hi @simotek @jengelh

This change is making a few packages failing to build:

lib2geom: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/lib2geom/standard/i586

libphonenumber: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/libphonenumber/standard/x86_64

rdma-core: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/rdma-core/standard/x86_64

rust1.69:test: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/rust1.69:test/standard/x86_64

rust1.71:test: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:H/rust1.71:test/standard/x86_64

Jan Engelhardt (jengelh) - 10 months ago

reviewer

lib2geom 1105488 libphonenumber 1105335->1105413 rdma-core 1105472 rust1.71 can't reproduce an error :-/ Anyway, time to reopen here because all is addressed and now hangs with the maintainers.