Overview
Request 1129209 revoked
DRAFT: this is a first draft of the new pgbadger package. Please review
and comment as needed. Enhancements can either be made directly in the
branch now or later in the accepted submission.
- update to 12.3
This is a maintenance release of pgBadger that fixes issues reported by
users since last release. It also adds some new features:
* Add option --include-pid to only report events related to a session
pid (%p). Can be used multiple time. Thanks to Henrietta Dombrovskaya
for the feature request.
* Add option --include-session to only report events related to the
session id (%c). Can be used multiple time. Thanks to Henrietta Dombrovskaya
for the feature request.
* Add option --dump-raw-csv to only parse the log and dump the information
into CSV format. No further processing is done, no report is generated.
Thanks to Henrietta Dombrovskaya for the feature request.
Here is the complete list of changes and acknowledgments:
* Update pgFormatter to version 5.5
* Fix end date of parsing with jsonlog format. Thanks to jw1u1 for the report.
* Fix typo in "Sessions per application". Thanks to fairyfar for the patch.
* Fix "INSERT/UPDATE/DELETE Traffic" chart bug. Thanks to fairyfar for the
patch.
* Fix parsing of orphan lines with bind queries. Thanks to youxq for the
report.
* Fix Analyze per table report with new PG versions. Thanks to Jean-Christophe
Arnu for the patch.
* Fix syslog entry parser when the syslog timestamp contains milliseconds.
Thanks to Pavel Rabel for the report.
- add systemd timer examples: beside the existing cron job example, this
allows people to get an idea how to automate the generation of reports
- introduce local cron macro: only recommend cron on older distributions
and leave the cron example file where it was historically (but place it
into the examples folder on newer distributions).
- get rid of old suse_version 11.3 check
- Created by lrupp
- In state revoked
-
Package maintainer:
emilianolangella
Request History
lrupp created request
DRAFT: this is a first draft of the new pgbadger package. Please review
and comment as needed. Enhancements can either be made directly in the
branch now or later in the accepted submission.
- update to 12.3
This is a maintenance release of pgBadger that fixes issues reported by
users since last release. It also adds some new features:
* Add option --include-pid to only report events related to a session
pid (%p). Can be used multiple time. Thanks to Henrietta Dombrovskaya
for the feature request.
* Add option --include-session to only report events related to the
session id (%c). Can be used multiple time. Thanks to Henrietta Dombrovskaya
for the feature request.
* Add option --dump-raw-csv to only parse the log and dump the information
into CSV format. No further processing is done, no report is generated.
Thanks to Henrietta Dombrovskaya for the feature request.
Here is the complete list of changes and acknowledgments:
* Update pgFormatter to version 5.5
* Fix end date of parsing with jsonlog format. Thanks to jw1u1 for the report.
* Fix typo in "Sessions per application". Thanks to fairyfar for the patch.
* Fix "INSERT/UPDATE/DELETE Traffic" chart bug. Thanks to fairyfar for the
patch.
* Fix parsing of orphan lines with bind queries. Thanks to youxq for the
report.
* Fix Analyze per table report with new PG versions. Thanks to Jean-Christophe
Arnu for the patch.
* Fix syslog entry parser when the syslog timestamp contains milliseconds.
Thanks to Pavel Rabel for the report.
- add systemd timer examples: beside the existing cron job example, this
allows people to get an idea how to automate the generation of reports
- introduce local cron macro: only recommend cron on older distributions
and leave the cron example file where it was historically (but place it
into the examples folder on newer distributions).
- get rid of old suse_version 11.3 check
lrupp revoked request
Revoking to add some informal text to the example scripts.
I have been told that there is an ongoing effort to convert cron jobs to systemd timers instead, and there are very few cron jobs left (about ~10 for all of Factory). Would it be better to leave the systemd timer and remove the cron job?
+1
Please have a deeper look at the spec file:
%if %{with cron} # keep the old behavior for now and install the cron job example into the cron directory: install -Dm 0644 %{SOURCE1} %{buildroot}%{_sysconfdir}/cron.d/%{name} %else install -m 0644 %{SOURCE1} %{buildroot}%{_defaultdocdir}/%{name}/examples/pgbadger-cron.sh %endifI did not want to break older distributions (15.1 and beyond) ad hoc. For them, the cron snipplet keeps as it was before.
For newer distributions, the cron snipplet will be installed under the documentation directory. In addition, there will be no recommendation of cron any longer.
This might break existing setups, where people have edited and enabled the cron job on their machines.
We could think about checking for a file /etc/cron.d/pgbadger.rpmnew in a %triggerpostun macro like:
But I currently don't think that this is really worth it.
But keeping the old cron script below /usr/share/doc/packages/pgbadger/examples/ as an example for someone who does not want to migrate should not harm - that's what I think.
+1
Let's add another README.txt in /usr/share/doc/packages/pgbadger/examples/, which informs the customers about how to use the example scripts. It might be helpful for them - and also allows us to point them towards possible security effects this might have.