Request 1129912 (accepted)

You're not reviewing the full diff of request 1129912 , but the diff to the superseded request 1129813 (Show full diff)

Overview

Request 1129912 accepted

- Add gtk2-check-attribute.patch (bsc#1217622): check for attribute
availability before accessing it.
Starting from GLib 2.76, the standard attribute getters in the
GFileInfo object will warn if the attribute is unset, instead of
silently bailing out and returning a default value.

Created by polslinux 12 months ago
In state accepted
Supersedes 1129813

Submit gtk2

Comments for request 1129912 0
Comments for request 1129813 2

Dominique Leuenberger (dimstar) - 12 months ago

reviewer target maintainer

Please have the changelog follow 4WH

Who (changes file, header section - given)
When (changes file, header section - given)
What
Why
How (changes file, added patch -given)

Also: where is the patch coming from? Is the patch submitted upstream? Add the respective Patch tag line (see https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Type_1:_minimal_single-line_comment_in_spec_file)

Paolo Stivanin (polslinux) - 12 months ago

author

Thanks Dom! Some followup questions:

this patch is a fix for upstream, but upstream won't patch it because gtk2 is no longer supported. I guess that PATCH-FIX-UPSTREAM is still the appropriate one, right?
the patch is coming from https://gitlab.gnome.org/GNOME/gtk/-/commit/c1fa916e88de20fc61dc06d3ff9f26722effa0df#note_1852594 , I've put the link in the spec file next to PATCH-FIX-UPSTREAM. Is there anything else I should do?