Overview

Request 1129813 superseded

- Add gtk2-check-attribute.patch (bsc#1217622).

Dominique Leuenberger's avatar
Dominique Leuenberger (dimstar) -
reviewer target maintainer

Please have the changelog follow 4WH

  • Who (changes file, header section - given)
  • When (changes file, header section - given)
  • What
  • Why
  • How (changes file, added patch -given)

Also: where is the patch coming from? Is the patch submitted upstream? Add the respective Patch tag line (see https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Type_1:_minimal_single-line_comment_in_spec_file)

Paolo Stivanin's avatar
Paolo Stivanin (polslinux) -
author

Thanks Dom! Some followup questions:

  1. this patch is a fix for upstream, but upstream won't patch it because gtk2 is no longer supported. I guess that PATCH-FIX-UPSTREAM is still the appropriate one, right?

  2. the patch is coming from https://gitlab.gnome.org/GNOME/gtk/-/commit/c1fa916e88de20fc61dc06d3ff9f26722effa0df#note_1852594 , I've put the link in the spec file next to PATCH-FIX-UPSTREAM. Is there anything else I should do?

Request History
Paolo Stivanin's avatar

polslinux created request

- Add gtk2-check-attribute.patch (bsc#1217622).

GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded

Paolo Stivanin's avatar

polslinux superseded request

superseded by 1129912

openSUSE Build Service is sponsored by
Places