Overview

Request 1130186 revoked

dependency for virtme-ng

Loading...

James Fehlig's avatar

Looks fine to me, but isn't Leap 15.4 EOL soon?


Robert Frohl's avatar

I am assuming the submitter of virtme had a reason to target Leap 15.4, would try to release that still there.

Plus I think Backports can also be used by SLE


James Fehlig's avatar

After a closer look, I'm not sure it's fine for 15.4. virtiofsd.spec has 'Conflicts: qemu-tools < 8'. We don't want it conflicting with qemu-tools, which provides things like qemu-img.


Dario Faggioli's avatar

No. In 15.4, virtiofsd is "embedded" in QEMU and, in fact, the "binary" is included in the qemu-tools package (which is the reason why we have the "Conflicts:" that also @jfehlig spotted):

dario@leap154:~> rpm -ql qemu-tools
/etc/qemu
/etc/qemu/bridge.conf
/usr/bin/analyze-migration.py
/usr/bin/qemu-edid /usr/bin/qemu-img
/usr/bin/qemu-io /usr/bin/qemu-keymap
/usr/bin/qemu-nbd /usr/bin/qemu-pr-helper
/usr/bin/qemu-storage-daemon
/usr/bin/vmstate-static-checker.py
/usr/bin/vmxcap /usr/lib/qemu-bridge-helper
/usr/lib/virtfs-proxy-helper
/usr/lib/virtiofsd   <===
...

Having and trying to install the standalone virtiofsd package in the distro is wrong, and will only cause problems.

Request History
Robert Frohl's avatar

rfrohl created request

dependency for virtme-ng


Robert Frohl's avatar

rfrohl moved maintenance target to openSUSE:Maintenance:18205


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Maintenance Bot's avatar

maintbot added Virtualization as a reviewer

Submission for None by someone who is not maintainer in the devel project (Virtualization). Please review


Maintenance Bot's avatar

maintbot accepted review

ok


Dario Faggioli's avatar

dfaggioli declined review

No. In 15.4, virtiofsd is "embedded" in QEMU and, in fact, the "binary" is included in the qemu-tools package (which is the reason why we have the "Conflicts:" that also @jfehlig spotted):

dario@leap154:~> rpm -ql qemu-tools
/etc/qemu
/etc/qemu/bridge.conf
/usr/bin/analyze-migration.py
/usr/bin/qemu-edid
/usr/bin/qemu-img
/usr/bin/qemu-io
/usr/bin/qemu-keymap
/usr/bin/qemu-nbd
/usr/bin/qemu-pr-helper
/usr/bin/qemu-storage-daemon
/usr/bin/vmstate-static-checker.py
/usr/bin/vmxcap
/usr/lib/qemu-bridge-helper
/usr/lib/virtfs-proxy-helper
/usr/lib/virtiofsd

Having and trying to install the standalone virtiofsd package in the distro is wrong, and will only cause problems.


Dario Faggioli's avatar

dfaggioli declined request

No. In 15.4, virtiofsd is "embedded" in QEMU and, in fact, the "binary" is included in the qemu-tools package (which is the reason why we have the "Conflicts:" that also @jfehlig spotted):

dario@leap154:~> rpm -ql qemu-tools
/etc/qemu
/etc/qemu/bridge.conf
/usr/bin/analyze-migration.py
/usr/bin/qemu-edid
/usr/bin/qemu-img
/usr/bin/qemu-io
/usr/bin/qemu-keymap
/usr/bin/qemu-nbd
/usr/bin/qemu-pr-helper
/usr/bin/qemu-storage-daemon
/usr/bin/vmstate-static-checker.py
/usr/bin/vmxcap
/usr/lib/qemu-bridge-helper
/usr/lib/virtfs-proxy-helper
/usr/lib/virtiofsd

Having and trying to install the standalone virtiofsd package in the distro is wrong, and will only cause problems.


Robert Frohl's avatar

rfrohl revoked request

discussed another option with Dario

openSUSE Build Service is sponsored by