This request supersedes:
request 1136265
(Show diff)
Overview
Loading...
author
source maintainer
target maintainer
Thanks for the hint about Qt5 vs Qt6. Does not make sense indeed ,-)
target maintainer
IMO the ######################################################################### ... lines can be removed
target maintainer
The provides/obsoletes need to be versioned (see also rpmlint). Using %{version} should work in this case, the other package is at 4.2.0 ATM
target maintainer
The ldconfig stuff can be replaced by %ldconfig_scriptlets
author
source maintainer
target maintainer
Cool, thanks for your precise review, really appreciated.
Login required, please
login
in order to comment
Request History
kfreitag created request
Even more feedback, thanks for the review!
Vogtinator accepted request
LGTM, I'll fix the minor issues after accepting and forward to oS:F. It's possible that the old owncloud-client-dolphin package has to be removed for this to pass installcheck.
Obsoletes should be
<, not<=Provides/obsoletes are not indented like the rest