Overview

Request 1142135 accepted

- Packaging improvements:
* _service change disabled to manual per osc deprecation warning:
WARNING: Command 'disabledrun/dr' is obsolete, please convert
your _service to use 'manual' and then 'manualrun/mr' instead.
* _service go_modules remove param compression same as default
* _service obs_scm param revision use git tag
* _service obs_scm use param revision not version for git tag
* _service obs_scm remove param versionrewrite-replacement
* Summary and Description clarify the purpose of this CLI tool
* Use Group: Development/Tools/Building instead of Other
* Use %%name macro where applicable to normalize common lines
across Go app packages. Also makes renaming binary easier when
required to handle package name conflict.
* Drop Requires: golang-packaging. The recommended Go toolchain
dependency expression is BuildRequires: golang(API) >= 1.x or
optionally the metapackage BuildRequires: go
* Update to BuildRequires: golang(API) >= 1.20 matching go.mod
* Remove %%{go_nostrip} macro which is no longer recommended
* Drop %%autosetup -D arg only needed for multiple invocations
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable
but none exist at this time.

Loading...
Request History
Jeff Kowalczyk's avatar

jfkw created request

- Packaging improvements:
* _service change disabled to manual per osc deprecation warning:
WARNING: Command 'disabledrun/dr' is obsolete, please convert
your _service to use 'manual' and then 'manualrun/mr' instead.
* _service go_modules remove param compression same as default
* _service obs_scm param revision use git tag
* _service obs_scm use param revision not version for git tag
* _service obs_scm remove param versionrewrite-replacement
* Summary and Description clarify the purpose of this CLI tool
* Use Group: Development/Tools/Building instead of Other
* Use %%name macro where applicable to normalize common lines
across Go app packages. Also makes renaming binary easier when
required to handle package name conflict.
* Drop Requires: golang-packaging. The recommended Go toolchain
dependency expression is BuildRequires: golang(API) >= 1.x or
optionally the metapackage BuildRequires: go
* Update to BuildRequires: golang(API) >= 1.20 matching go.mod
* Remove %%{go_nostrip} macro which is no longer recommended
* Drop %%autosetup -D arg only needed for multiple invocations
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable
but none exist at this time.


Jeff Kowalczyk's avatar

jfkw accepted review

Review OK for devel:languages:go


Jeff Kowalczyk's avatar

jfkw approved review

Review OK for devel:languages:go


Jeff Kowalczyk's avatar

jfkw accepted request

Accept to devel:languages:go

openSUSE Build Service is sponsored by