This request is superseded by
request 1145317
(Show diff)
Overview
Request 1144664 superseded
@badshag400 All items completed, thank you very much for your support, attention and patience.
- Created by cabelo
- In state superseded
- Supersedes 1144041
- Superseded by 1145317
Loading...
target maintainer
Many thanks, but the spec file does not follow openSUSE guidelines in numerous ways.
- Line number one mentions incorrect package name.
- The Packager tag must be omitted.
- Drop the debugging comments, the unnecessary
pwd
command - CMAKE_INSTALL_PREFIX should be
%prefix
which is automatically set by%cmake
. - The
%cmake
macro is incorrectly invoked. - The .changes file does not conform to guidelines. To simplify this, you may delete all the entries that you currently have there and simply mention "Initial package." as the only entry since this is a new package to the science project.
- Run
spec-cleaner
on the spec file to clean it up. - Fix License tag according to SPDX short forms.
Please supersede with fixes sr.
target maintainer
Additionally:
- Do not disable debug package.
- Do not disable post install and brp checks. Disabling these checks are simply not allowed in any package in science or Factory. Fix any issues these may point to.
- Be more specific when suppressing rpmlint warnings, and do it for specific subpackages.
- Use
%make_build
instead ofmake -j...
author
source maintainer
@badshag400 Thank you, I'm working on the errors and observations, thank you.
Login required, please
login
in order to comment
Request History
cabelo created request
@badshag400 All items completed, thank you very much for your support, attention and patience.
ldconfig for dlopen'ed plugins doesn't make sense.
%cmake_build
%cmake_install
This should be built for all archs, unless there are very good reasons for not doing it.
https://github.com/openvinotoolkit/openvino?tab=readme-ov-file#supported-hardware-matrix suggests otherwise.
cmake, scons; make, ninja ... looks strange.
No ccache on OBS, thats just unnecessary overhead.
Looks suspicious ...
both very likely actually unused
apparently unused
What for, when python bindings are explicitly disabled?
implicit, please remove
Executable packages should not have a version
devel packages should not have a version
@badshag400 All items completed, thank you very much for your support, attention and patience.
Hi @StefanBruens All tasks above completed, thank you very much for your great support and patience.