Request 1145428 (review)

Overview

Request 1145428 review

- Update to current stable go1.22
Refs boo#1218424 go1.22 release tracking

Created by jfkw 4 months ago
In state review
Open review for factory-staging

Submit go

Comments for request 1145428 8

Jeff Kowalczyk (jfkw) - 4 months ago

author source maintainer

I may have submitted this go metapackage update too early. go1.22 has been accepted, but Staging:H does not yet resolve that package. If needed, can revoke and resubmit at a future time.

Ana Guerrero (anag+factory) - 4 months ago

reviewer

No problem,I'll link go1.22

Jeff Kowalczyk (jfkw) - 4 months ago

author source maintainer

I noticed a build failure for golang-github-prometheus-promu on i586. Fixed in SR 1145684 to server:monitoring/golang-github-prometheus-promu.

Ana Guerrero (anag+factory) - 4 months ago

reviewer

waiting for golang-gb-prometheus-promu

Ana Guerrero (anag+factory) - 4 months ago

reviewer

@jfkw

Making go1.22 by default makes transactional-update-notifier fail on i586:

[    9s] Executing(%build): /usr/bin/bash -e /var/tmp/rpm-tmp.NtUOka
[    9s] + umask 022
[    9s] + cd /home/abuild/rpmbuild/BUILD
[    9s] + /usr/bin/rm -rf /home/abuild/rpmbuild/BUILDROOT/transactional-update-notifier-1.1.0.2-2.33.i386
[    9s] ++ dirname /home/abuild/rpmbuild/BUILDROOT/transactional-update-notifier-1.1.0.2-2.33.i386
[    9s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT
[    9s] + /usr/bin/mkdir /home/abuild/rpmbuild/BUILDROOT/transactional-update-notifier-1.1.0.2-2.33.i386
[    9s] + cd transactional-update-notifier-1.1.0.2
[    9s] + export 'GOFLAGS=-mod=vendor -buildmode=pie'
[    9s] + GOFLAGS='-mod=vendor -buildmode=pie'
[    9s] + /usr/bin/make -O -j4 V=1 VERBOSE=1
[    9s] cp org.opensuse.tukit.Updated.conf build/org.opensuse.tukit.Updated.conf
[    9s] sed -e 's|[@bindir](https://build.opensuse.org/users/bindir)@|/usr/bin|' transactional-update-notifier.service.in > build/transactional-update-notifier.service
[    9s] mkdir -p build
[    9s] CGO_ENABLED=0 go build -mod=vendor -buildmode=pie -ldflags "-X main.Version=1.1.0" -o build/transactional-update-notifier
[    9s] -buildmode=pie requires external (cgo) linking, but cgo is not enabled
[    9s] make: *** [Makefile:23: transactional-update-notifier] Error 1
[    9s] error: Bad exit status from /var/tmp/rpm-tmp.NtUOka (%build)

Ana Guerrero (anag+factory) - 4 months ago

reviewer

ftbfs transactional-update-notifier

Jeff Kowalczyk (jfkw) - 4 months ago

author source maintainer

For compatibility with go1.22 and recent point releases of go1.21, Go application packages will need to remove export CGO_ENABLED=0 if also using -buildmode=pie or any of several other options that cause the external linker to be used. Go has an internal linker that is the default on OS and architectures where support is completed.

I created a tracking issue https://bugzilla.opensuse.org/show_bug.cgi?id=1221095. It will take some time for me to create the 40+ SRs to affected packages, have them accepted and finally forwarded to Factory. If keeping this SR for the go metapackage staged for an addition time creates problems, I can revoke and submit later.

Ana Guerrero (anag+factory) - 3 months ago

reviewer

Thank you for the update Jeff! This SR can stay open in the meantime.