Overview

Request 1145456 accepted

- remove some old rpmlintrc entries
- remove old (< 12.0) SUSE macros from spec file
- nagios-dch and nagios-contrib can be noarch
- use autopatch macro
- set right permission and ownership for /var/log/nagios/config.err
even if this file is just a ghost file in RPM
- use /run/nagios instead of /var/run/nagios for pid file
- get rid of really old (SLE9) fix for nagios command group (was
group www at that time). Since SLE10, we use and own group
(nagcmd) instead. As we do not support to migrate from SLE9 to
SLE11 and beyond directly, this migration should have been done
long time ago already

- Do not provide user/group symbols and actually stop generating
those users/groups alltogether. The package system-user-nagios is
taking care of the user setup.

- provide user(nagios), group(nagios), group(wwwrun), user(nagcmd)
bsc#1219600

Loading...

Ansgar Esztermann's avatar
author source maintainer

Hmm. From the point of view of the Factory package, the changelog entries are (mostly) superfluous; they result from a pair of requests that cancel each other. They have been accepted in the devel project, but the first has been rejected by Factory. What's the usual way to deal with such situations? Do we just leave them in? Create a new request from the devel proj to Factory?


Lars Vogdt's avatar
reviewer source maintainer

FYI: I'm currently working on this right now.

To give credits to whom they may concern, I usually keep the changelog entries as they are (if possible; if it's not too much work or just a change that gets directly reverted).

Request History
Lars Vogdt's avatar

lrupp created request

- remove some old rpmlintrc entries
- remove old (< 12.0) SUSE macros from spec file
- nagios-dch and nagios-contrib can be noarch
- use autopatch macro
- set right permission and ownership for /var/log/nagios/config.err
even if this file is just a ghost file in RPM
- use /run/nagios instead of /var/run/nagios for pid file
- get rid of really old (SLE9) fix for nagios command group (was
group www at that time). Since SLE10, we use and own group
(nagcmd) instead. As we do not support to migrate from SLE9 to
SLE11 and beyond directly, this migration should have been done
long time ago already

- Do not provide user/group symbols and actually stop generating
those users/groups alltogether. The package system-user-nagios is
taking care of the user setup.

- provide user(nagios), group(nagios), group(wwwrun), user(nagcmd)
bsc#1219600


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Ana Guerrero's avatar

anag+factory added openSUSE:Factory:Staging:adi:55 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:55"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:adi:55"


Dominique Leuenberger's avatar

dimstar accepted review


Saul Goodman's avatar

licensedigger accepted review

ok


Ana Guerrero's avatar

anag+factory added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Ana Guerrero's avatar

anag+factory accepted review

Unstaged from project "openSUSE:Factory:Staging:adi:55"


Ana Guerrero's avatar

anag+factory added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:74"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:adi:74"


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:74 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:74 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:74 got accepted.

openSUSE Build Service is sponsored by