Overview
Why should that go to X11:Utilities? It doesn't use X11.
WoeUSB-ng is actually a GUI program in comparison to WoeUSB, which is in this develproject. so that's why I thought, putting it here would be fine
Hmm, so WoeUSB already shouldn't be here. But there is probably a very logical explanation why it is here, probably because another package is here which also doesn't belong which again...
Seems this whole project idea has a lot of flaws :-)
Ok. Some recommendations:
- Add the missing return at the end of the spec
- Replace the sed's with a patch file - with correct patch tagging: https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Patch_markup_(also_called_%22Tagging_patches%22)
- Why: Because a patch will fail when the code changes, the sed calls usually silently get obsoleted
- You can provide a proper patch upstream, so the issue vanishes for good
- For the find call: Why are the slashes escaped and why don't you use %{_bindir} in the replace part?
- Description should be line-wrapped at about 80 chars boundary
- I'd add the initial version number in the changes comment in the changes file
P.S. I've never seen the creative %{url} usage before ;-)
well, I guess over the years stuff changed. and for example for WoeUSB, it was rewritten to be a cli util in 2021.
with the sed I wouldn't know how to patch it, as I need to add %{buildroot} otherwise it tries to install it into the vm OS in %{_bindir} (as the path is hardcoded)
my bad with the escaped find command. found something similar, and adapted it to this package, and overlooked that the slashes don't have to be escaped.
any project you can recommend for this utility then?
(about the %{url} I quite like it, so the source is not too long)
Well, if WoeUSB is already here it's probably ok.
For the Patch: Usually you use DESTDIR variable on commandline or as environment variable to the tools and these then add this in front of the real installpath (or not when empty). As an empty DESTDIR is essentially a no-op then you only need to ensure that DESTDIR can be passed to the tool. Don't know how this is typically done for setup.py.
https://www.gnu.org/prep/standards/html_node/DESTDIR.html For the others it's typically https://www.gnu.org/prep/standards/html_node/Directory-Variables.html#Directory-Variables
Best would be when you can use DESTDIR, bindir and datadir in the software, set these to the old defaults, but allow to override them via call argument or environment variable. That patch will be easy acceptable for upstream and solve this in a proper way.
As said I don't know how to do for python setup.py, but I'm pretty sure there will be examples in the net. That way of installing is the default for several years now.
See comments in sr#1145521