This request is superseded by
request 1167613
(Show diff)
You're not reviewing the full diff of
request 1146605
, but the diff to the superseded
request 1145317
(Show full diff)
Overview
Request 1146605 superseded
Hi @StefanBruens All tasks above completed, thank you very much for your great support and patience.
- Created by cabelo
- In state superseded
- Supersedes 1145317
- Superseded by 1167613
Loading...
author
source maintainer
@StefanBruens Did I do anything else wrong? Thank you very much for your great support and patience.
@Dmitry_R, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @dstoecker, @eeich, @kwk, @lrupp, @mslacken, @openfoam, @psmt: review reminder
Login required, please
login
in order to comment
Request History
cabelo created request
Hi @StefanBruens All tasks above completed, thank you very much for your great support and patience.
badshah400 declined request
See comments. Thanks for the sr.
This looks wrong, perhaps you mean
%if 0%{?suse_version} < 1600instead? There are also additional gccBuildRequiresjust above.done
Is this really needed for the build?
Thank You, done.
patchelfdoes not seem to be used anywhere any more. Probably no longer needed?done
lib*Requires should be left for RPM to automatically determine. These two explicitRequiresshould probably be dropped.done
Must be
lib%{name}-auto-batch-plugin = %{version}done
Let
%cmakedetermine the right place to start configuring by dropping the unnecessary..and terminating the command at the previous line.done
Not needed in light of following line. From the mkdir manual
done
Duplicate of Line 188
done
%versionmust not be part of the package name.done
All three lines above refer to standard directories. If you have to own them, you are doing something wrong...
done
Be explicit in naming what files/dirs are included here and in the following.
done
Probably unnecessary.
done
Purely aesthetical, but please ensure line breaks at 79 characters for better readability.
done
@StefanBruens Did I do anything else wrong? Thank you very much for your great support and patience.
@Dmitry_R, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @dstoecker, @eeich, @kwk, @lrupp, @mslacken, @openfoam, @psmt: review reminder
Do I need to do anything else?
You also have to enable builds for Tumbleweed. Not building for TW is a blocker against inclusion into the obs://science project.
Thanks for the efforts. Much appreciated.
Thank you very much, it took me a while to respond because I had serious personal problems.
Most of my points are already red flags raised by rpmlint. Please do not ignore rpmlint's errors at any cost, and try to fix the warnings to the extent possible.
I will start working on the items above.