Overview
Request 1167613 superseded
@badshah400 All above tasks completed, thank you very much for your great support and patience. It took me a while to finish because I have a lot of personal problems. When approved, opensuse will be the first distribution with native Intel generative AI packages in the world.
- Created by cabelo
- In state superseded
- Supersedes 1146605
- Superseded by 1167694
This looks wrong, perhaps you mean %if 0%{?suse_version} < 1600 instead? There are also additional gcc BuildRequires just above.
Is this really needed for the build?
patchelf does not seem to be used anywhere any more. Probably no longer needed?
lib* Requires should be left for RPM to automatically determine. These two explicit Requires should probably be dropped.
Must be lib%{name}-auto-batch-plugin = %{version}
Let %cmake determine the right place to start configuring by dropping the unnecessary .. and terminating the command at the previous line.
Not needed in light of following line. From the mkdir manual
mkdir --help ... -p, --parents no error if existing, make **parent directories** as needed,
%version must not be part of the package name.
All three lines above refer to standard directories. If you have to own them, you are doing something wrong...
Be explicit in naming what files/dirs are included here and in the following.
Purely aesthetical, but please ensure line breaks at 79 characters for better readability.
@StefanBruens Did I do anything else wrong? Thank you very much for your great support and patience.
@Dmitry_R, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @dstoecker, @eeich, @kwk, @lrupp, @mslacken, @openfoam, @psmt: review reminder
You also have to enable builds for Tumbleweed. Not building for TW is a blocker against inclusion into the obs://science project.
Thanks for the efforts. Much appreciated.
Thank you very much, it took me a while to respond because I had serious personal problems.
Most of my points are already red flags raised by rpmlint. Please do not ignore rpmlint's errors at any cost, and try to fix the warnings to the extent possible.
I will start working on the items above.
Request History
cabelo created request
@badshah400 All above tasks completed, thank you very much for your great support and patience. It took me a while to finish because I have a lot of personal problems. When approved, opensuse will be the first distribution with native Intel generative AI packages in the world.
Many thanks for the updated sr. This looks like it is almost there for me, so thanks a lot for all the work.
I just have a few minor issues that you may want to fix before we move this over:
%cmakemust not end with... It is a macro that automatically finds the top-levelCMakeLists.txtfile in the project. Just replace..with%{nil}.%post/%postunscriptlets should only be run for shared library packages (i.e. only for packages installing%{_libdir}/*.so.*files and not for -devel pkg or any others.)lib%{name}-develpackage must be renamed to%{name}-devel. Thelibprefix to a package name only makes sense for shared lib packages. Also similarly rename the plugin packages.%dirif they are exclusive to a specific package. For example, get rid of all the lines listed under%files -n %{name}-sampleand simply put%{_datadir}/%{name}/instead.cpandmvcommands; the present format makes it difficult to read. I thought at first glancecponly had a single arg, then realising I needed to scroll right to see the destination arg.makeandgccfromBuildRequires. These are automatically always pulled into buildroot.sedof cmake and pkgconfig files in%installbut I guess the install scripts do not work well and perhaps this is the only way. I would still report it upstream if possible.And... I think that is it! Thanks again.
Sorry to hear you had problems; I hope you are doing all better now.
HI @badshah400 I did almost everything:
Answer: I did this to maintain compatibility with Intel's rpm packages and not lose compatibility with Intel's official documentation. Ok?
Answer: I'm not happy either, but I'm looking at this with the Intel folks in the next release. You don't need to worry about this.
Can we proceed like this?
I did almost everything
Where is it? I still see:
%post(un)scriptlets, despite explanations for where it should be used. Currently it is called even for the package that only installs licenses!%cmakeinvocation that ends with&{nil}instead of%{nil}and certainly leads to a build failureRedundant dir ownership like:
%dir %{_datadir}/openvino %{_datadir}/openvino/samples/cpp/* %{_datadir}/openvino/samples/c/*is everywhere in the file lists.
I did this to maintain compatibility with Intel's rpm packages and not lose compatibility with Intel's official documentation. Ok?
Sorry, but as much as it would be amazing to have this package for openSUSE, it should nonetheless confirm to openSUSE packaging guidelines, not Intel's. So, nothing but shared library packages are allowed have the leading
libin their name.Thanks for talking to upstream about this. I think we can accept this part as it is for now.
HI @badshah400 I executed all the requests, is something missing?