Overview

Request 1147030 accepted

- Update to version 1.90.2.15.git+be82397:
* Revert "ci: Update last ABI break"
* Revert "build: Bump the library soname after recent changes"
* Revert "all: Remove Lid handling"
* Revert "lib: Remove deprecated up_client_get_devices()"
* dbus: org.freedesktop.UPower: EnergyRate is a positive value
* linux: Adjust test_bluetooth_le_device for dbusmock 0.30.1
* linux: stop assuming power supply of unknown type as battery
* linux: drop f-literals without format string
* linux: prefer is not None over !=
* build: make 'udevrulesdir' and 'udevhwdbdir' as Linux-only
- Introduce _service obs_scm and obsinfo files for automated
update service via:
osc service mr

Loading...

Dominique Leuenberger's avatar

Thanks Thomas.

It being as GNOME-maintaiern owned packaged, I'd prefer it to have the same service / version format as other packages in that realm.

adwaita-icon-theme for example has this _service file:

<?xml version="1.0"?>
<services>
  <service name="obs_scm" mode="manual">
    <param name="scm">git</param>
    <param name="url">https://gitlab.gnome.org/GNOME/adwaita-icon-theme.git</param>
    <param name="revision">46.beta</param>
    <param name="versionformat">[@PARENT\_TAG](https://build.opensuse.org/users/PARENT_TAG)@+[@TAG\_OFFSET](https://build.opensuse.org/users/TAG_OFFSET)@</param>
    <param name="versionrewrite-pattern">v?(.*)\+0</param>
    <param name="versionrewrite-replacement">\1</param>
<!--    <param name="changesgenerate">enable</param> -->
  </service>
  <service name="tar" mode="buildtime"/>
  <service name="recompress" mode="buildtime">
    <param name="file">*.tar</param>
    <param name="compression">zst</param>
  </service>
  <service name="set_version" mode="manual" />
</services>

Thomas Renninger's avatar
author source maintainer target maintainer

Hi Dominique,

this one hit my brain hard:

From what I could see from other gnome packages it seems as if they use pretty much the same than I did, but without any git hash in the end?

/mounts/dist/install/SLP/openSUSE-Tumbleweed/x86_64/DVD1/noarch/gnome-icon-theme-3.12.0-5.15.noarch.rpm

So I would simply go for (OMG the https://build.opensuse.org/users/PARENT_TAG)... is coming from markdown interpretation?!?

<param name="versionformat">[@PARENT\_TAG](https://build.opensuse.org/users/PARENT_TAG)@.[@TAG\_OFFSET](https://build.opensuse.org/users/TAG_OFFSET)@</param>
<param name="versionrewrite-pattern">v(.*)</param>


Dominique Leuenberger's avatar

Accepted your SR and changed the service file to align with the other packages maintained by the GNOME Team:

https://build.opensuse.org/package/rdiff/Base:System/upower?linkrev=base&rev=153

FWIW, I use this script to update packages https://github.com/DimStar77/openSUSE-helpers/blob/master/Tumbleweed-Dev-Scripts/obs_scm-update.sh

extracts NEWS files and meson diffs (helping in assessing changes to BuildRequires for example)


Thomas Renninger's avatar
author source maintainer target maintainer

Thanks. This is very much appreciated!

Request History
Thomas Renninger's avatar

trenn created request

- Update to version 1.90.2.15.git+be82397:
* Revert "ci: Update last ABI break"
* Revert "build: Bump the library soname after recent changes"
* Revert "all: Remove Lid handling"
* Revert "lib: Remove deprecated up_client_get_devices()"
* dbus: org.freedesktop.UPower: EnergyRate is a positive value
* linux: Adjust test_bluetooth_le_device for dbusmock 0.30.1
* linux: stop assuming power supply of unknown type as battery
* linux: drop f-literals without format string
* linux: prefer is not None over !=
* build: make 'udevrulesdir' and 'udevhwdbdir' as Linux-only
- Introduce _service obs_scm and obsinfo files for automated
update service via:
osc service mr


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar approved review


Dominique Leuenberger's avatar

dimstar accepted request

openSUSE Build Service is sponsored by