Careful here! Requiring %{python_module …} is always wrong (only for BuildRequires). It expands to 'all python flavors' (in this specific spec file it's working as intended, as pythons is being redefined. That in itself is already not correct - as this package here does not build python modules - it's just a shortcut to use to python_build macros)

Summary: it works here as intended, but the construct should be avoided to not fall into traps later on.

Michal Suchanek (michals) - 9 months ago

So what would be the RightWay™ to do this?

The python version is restricted by %define pythons python3 as well as %{?sle15_python_module_pythons} which means that %{python_module argcomplete} is not a constant, it varies across releases. Or if it does not it's a bug.

How should the runtime dependency look like in this case?

---

Dominique Leuenberger (dimstar) - 9 months ago

especially with sle15_python_module_pythons I'm not sure if this is guaranteed to stay 'one python version' only - that's imho the biggest danger.

I'm inclined to accept it - but will check with the other reviewers

mrueckert wrote (1149491) (https://build.opensuse.org/request/show/1149491) a much safer and cleaner solution would be something like

%if 0%{?suse_version} >= 1600
%global pythons python
%else
%global pythons python311
%endif

[snip]

BuildRequires:  %{pythons}-argcomplete
BuildRequires:  %{pythons}-setuptools
Requires:       %{pythons}-argcomplete
Requires:       %{pythons}-setuptools

Marcos de Souza (mpdesouza) - 9 months ago

source maintainer

Shouldn't the first be python3 instead of just python? Thanks!