Request 1157097 (accepted)

This request supersedes: request 1156977 (Show diff)

Overview

Request 1157097 accepted

mention additional -devel package dependencies added in changelog

Created by embar 9 months ago
In state accepted
Supersedes 1156977

Submit pspp

Comments for request 1157097 6
Comments for request 1156977 2

Dominique Leuenberger (dimstar) - 9 months ago

reviewer

%check
export TESTSUITEFLAGS='-v -j128'
%make_build check || /bin/true
[ -f ./tests/testsuite.log ] || echo "check did not run" > ./tests/testsuite.log
mkdir $RPM_BUILD_ROOT/%{_datadir}/pspp/tests
# remove nondeterministic bits to make package build reproducible:
perl -i -pe '
  s/ (starting|ending) at:.*/ $1 at: [scrubbed]/;
  s/(test suite duration:).*/$1 [scrubbed]/;
  s/(hostname =) .*/$1 [hostscrubbed]/;
  s/^(\| on) [a-zA-Z0-9._-]+/$1 [hostscrubbed]/;
  s/ \(\d+m.*\ds\)/([durationscrubbed])/;
  s/20\d\d-\d\d-\d\d \d\d:\d\d:\d\d\.\d+ [+-]\d\d00/[datescrubbed]/;
  s!(bin/ld: /tmp/conftest\.)\w+!$1[randomnessscrubbed]!;
  s!^(\| \./configure: line \d+: *)\d+ (Aborted)!$1 [PIDscrubbed] $2!;
' ./tests/testsuite.log
cp ./tests/testsuite.log $RPM_BUILD_ROOT/%{_datadir}/pspp/tests/

%check is not supposed to modify %{buildroot} (old error - won't decline for it today)

Mindaugas Baranauskas (embar) - 9 months ago

author source maintainer

moving mentions of $RPM_BUILD_ROOT outside %check is enough?

Dominique Leuenberger (dimstar) - 9 months ago

reviewer

depending what they do, yes.. .basically you should ensure that %check only READS, but does not write anything into %buildroot (otherwise the package build differed between check enabler or disabled)

Mindaugas Baranauskas (embar) - 9 months ago

author source maintainer

actually It writes to disk test results, thus maybe it is ok to clear "%check" line, but execute remaining part?

Dominique Leuenberger (dimstar) - 9 months ago

reviewer

that does not sound like relevant data to ship to all user disks -I'd simply not write that log to %buildroot

Mindaugas Baranauskas (embar) - 9 months ago

author source maintainer

Thanks. Fixed in https://build.opensuse.org/request/show/1158060

Marcus Rueckert (darix) - 9 months ago

reviewer

your documentation changes also required all the new build requires?

Mindaugas Baranauskas (embar) - 9 months ago

author source maintainer

Actually no, not related to documentation, just adding few automatically suggested dependencies to -devel package to remove warning at end of build about probably missing dependencies dependencies