Overview

Request 1157535 accepted

Include the Fast Lines of Code Counter tool into the devel:tools project.

Loading...

Martin Pluskal's avatar

58+# No idea why the below is needed - build fails without these 59+#/usr/bin/ 60+#/usr/share/

Build obviosly does not fail anymore - why would you keep this in spec file?


Martin Pluskal's avatar

48+mkdir -p %{buildroot}/usr/bin/ 49+mkdir -p %{buildroot}/usr/share/man/man1/

You seem to be upstream of this - I would suggest to use "install -D" in makefile ...


Martin Pluskal's avatar

From build log: [ 12s] g++ -MM -c -Wall -O3 -std=c++11 -flto classifier.cc > classifier.d [ 12s] g++ -MM -c -Wall -O3 -std=c++11 -flto counters.cc > counters.d

opflags (distribution wide compiler flags are not honored), also -03 is usually strongly discouraged

CXXFLAGS ?= in make file should be used


Martin Pluskal's avatar

why exactly is git buildrequired?

Are you aware that buildrequires means that package is available during build, but it does not make it runtime dependency?

If git is runtime dependency there should be Required: git

If git is really build dependency, you should buildrequire git-core to avoid slowing build via pulling unnecessary stuff ...


Request History
Joerg Roedel's avatar

joro created request

Include the Fast Lines of Code Counter tool into the devel:tools project.


Martin Pluskal's avatar

pluskalm accepted request

let me accept this and fix most stuff

openSUSE Build Service is sponsored by