Overview

Request 1164096 superseded

update %check

Loading...

Dominique Leuenberger's avatar
reviewer target maintainer

Sorry, I'm slow in reviewing this :(

+Version: 0.3.0+git20240401.330f67d That seems not accurate - 0.3.0 has not been tagged, and as such this version can barely be ahead of 0.3.0. The app identifies itself as 0.3.0 - but as that's not yet released, you more likely want a Version: 0.3.0~git…


Dominique Leuenberger's avatar
reviewer target maintainer

_service:

+ <param name="versionformat">0.3.0+git%cd.%h</param>

please see about every other package in GNOME:Factory how we create the version entry (it's basiclaly always [@PARENT\_TAG](https://build.opensuse.org/users/PARENT_TAG)@+[@TAG\_OFFSET](https://build.opensuse.org/users/TAG_OFFSET)@)


Dominique Leuenberger's avatar
reviewer target maintainer

from _service:

+  <service name="recompress" mode="manual">
+    <param name="file">*.tar</param>
+    <param name="compression">zst</param>
+  </service>

tar and recompress services can be set as mode="buildtime" - check in the .obscpio instead of the .tar.zst


Dominique Leuenberger's avatar
reviewer target maintainer
<service name="tar_scm" mode="manual">

please use obs_scm service


Dominique Leuenberger's avatar
reviewer target maintainer
+%check
+#non available

I'd think you can still add %meson_test here though - if tests ever appear, they are already enabled. meson should fall through if there are no tests

Request History
Richard Rahl's avatar

rrahl0 created request

update %check


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Richard Rahl's avatar

rrahl0 superseded request

superseded by 1164369

openSUSE Build Service is sponsored by