Overview
Request 1166791 accepted
- Turn terminal flag setup into function
- Bump version: 3.0.11 → 3.0.12
- Fix race condition on connection check
- set PS1 prompt via sci env
- Add terminal settings for pty stdout in sci
disable ECHO
- Fix invalid early exit condition
- Bump version: 3.0.10 → 3.0.11
- Fix build for Leap
Issues on the gcc side for static targets, disable
sci static build for older targets, e.g Leap
- Prevent use of socat in firecracker-pilot
Do not shell out socat and use proper UnixListener/UnixStream
to do this job. This version of the commit works but I stumbled
across a few issues:
1. Permission denied when the UnixListener runs as user and the
firecracker process was called as root (run_as: root in the flake).
The former implementation ran socat via sudo in the same way as
the firecracker process. Thus if you register the flake to
run as root it can now also only be called as root, which is
acceptable.
2. The behavior in interactive sessions differs compared to socat.
- Created by marcus.schaefer
- In state accepted
Request History
marcus.schaefer created request
- Turn terminal flag setup into function
- Bump version: 3.0.11 → 3.0.12
- Fix race condition on connection check
- set PS1 prompt via sci env
- Add terminal settings for pty stdout in sci
disable ECHO
- Fix invalid early exit condition
- Bump version: 3.0.10 → 3.0.11
- Fix build for Leap
Issues on the gcc side for static targets, disable
sci static build for older targets, e.g Leap
- Prevent use of socat in firecracker-pilot
Do not shell out socat and use proper UnixListener/UnixStream
to do this job. This version of the commit works but I stumbled
across a few issues:
1. Permission denied when the UnixListener runs as user and the
firecracker process was called as root (run_as: root in the flake).
The former implementation ran socat via sudo in the same way as
the firecracker process. Thus if you register the flake to
run as root it can now also only be called as root, which is
acceptable.
2. The behavior in interactive sessions differs compared to socat.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
mstrigl accepted review
Accepted review for by_group opensuse-review-team request 1166791 from user factory-auto
anag+factory added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:29"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:adi:29"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:29 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:29 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:29 got accepted.