Overview
Request 1166883 new
- Update to gnu-efi 3.0.18:
* Add pkgconfig file
* Make ELF constructors and destructors work
* Make CHAR8 and similar be defined the same way edk2 does it
* Switch to -fPIE
* Merge all rela sections into one
- gnu-efi-bsc1182057-support-sbat-section.patch:
* Restore ARM32 SBAT crt0 patch as binutils doesn't actually
support it
* Add SBAT support for RISC-V 64
I just returned from vacation. Will look into the submission soon.
Looks fine to me in general.
As for %build section, per Build system recipes(https://en.opensuse.org/openSUSE:Build_system_recipes), %make_build is equivalent to make %{?_smp_mflags}, so replacing the make command makes sense to me. Personally, I'd like to keep the 'RPM OPT FLAGS' warning.
@rwill any other suggestion?
True about %optflags although it needs refining the old statement is misleading
Request History
gmbr3 created request
- Update to gnu-efi 3.0.18:
* Add pkgconfig file
* Make ELF constructors and destructors work
* Make CHAR8 and similar be defined the same way edk2 does it
* Switch to -fPIE
* Merge all rela sections into one
- gnu-efi-bsc1182057-support-sbat-section.patch:
* Restore ARM32 SBAT crt0 patch as binutils doesn't actually
support it
* Add SBAT support for RISC-V 64
@gary_lin @rwill
Updated warning as %make_build works now (one of my upstream fixes) but OPTFLAGS shouldn't be used as UEFI doesn't use shared C Library (it uses GLIBC in freestanding mode)
LGTM. I'll poke rwill and see if he is fine with the change.
@gary_lin, @rwill: review reminder